Actions
Bug #17482
closedIncorrect concatentation of environment import strings to form sentences
Status:
Rejected
Priority:
Normal
Assignee:
Category:
Internationalization
Target version:
Description
Some of the newly extracted strings in #15779 are incorrectly concatenated to form sentences. They must be extracted and translated as one - individual words can't be translated and added together, it will not work in some languages.
https://github.com/theforeman/foreman/commit/eb371ca33dcdd7a4f71d3cda0cfcad701cd3ae7e#diff-e9a92ed45620b6f0de59ab2e0bd3c791R18
https://github.com/theforeman/foreman/commit/eb371ca33dcdd7a4f71d3cda0cfcad701cd3ae7e#diff-e9a92ed45620b6f0de59ab2e0bd3c791R41
It's been separated into the form:
_("Update") + " " + _("environment") + name + " (5 " + _("classes") + ")"
This should be:
_("Update environment %{environment} (%{count} classes)")
and should also use n_() to handle plural/non-plural forms.
The string "Update on background" is also added, which should be "Update in the background" or possibly, "Update in background".
Actions