Project

General

Profile

Bug #17494

Test fails because of the stray `end` in the test file

Added by Abhay Kadam almost 2 years ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tests
Target version:
Difficulty:
trivial
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

I get the following stacktrace while executing a test suite:

SyntaxError: /home/abhay/devel/foreman/test/models/nics/managed_test.rb:159: syntax error, unexpected keyword_end, expecting end-of-input
/home/abhay/.rvm/gems/ruby-2.3.0/gems/activesupport-4.2.7.1/lib/active_support/dependencies.rb:244:in `rescue in load_dependency'
/home/abhay/.rvm/gems/ruby-2.3.0/gems/activesupport-4.2.7.1/lib/active_support/dependencies.rb:237:in `load_dependency'
/home/abhay/.rvm/gems/ruby-2.3.0/gems/activesupport-4.2.7.1/lib/active_support/dependencies.rb:274:in `require'
/home/abhay/.rvm/gems/ruby-2.3.0/gems/railties-4.2.7.1/lib/rails/test_unit/sub_test_task.rb:114:in `block (3 levels) in define'
/home/abhay/.rvm/gems/ruby-2.3.0/gems/railties-4.2.7.1/lib/rails/test_unit/sub_test_task.rb:114:in `each'
/home/abhay/.rvm/gems/ruby-2.3.0/gems/railties-4.2.7.1/lib/rails/test_unit/sub_test_task.rb:114:in `block (2 levels) in define'
/home/abhay/.rvm/gems/ruby-2.3.0/gems/railties-4.2.7.1/lib/rails/test_unit/sub_test_task.rb:113:in `each'
/home/abhay/.rvm/gems/ruby-2.3.0/gems/railties-4.2.7.1/lib/rails/test_unit/sub_test_task.rb:113:in `block in define'
/home/abhay/.rvm/gems/ruby-2.3.0/gems/railties-4.2.7.1/lib/rails/test_unit/sub_test_task.rb:20:in `invoke_rake_task'
/home/abhay/.rvm/gems/ruby-2.3.0/gems/railties-4.2.7.1/lib/rails/test_unit/testing.rake:8:in `block in <top (required)>'
/home/abhay/.rvm/gems/ruby-2.3.0/gems/activesupport-4.2.7.1/lib/active_support/dependencies.rb:268:in `load'
/home/abhay/.rvm/gems/ruby-2.3.0/gems/activesupport-4.2.7.1/lib/active_support/dependencies.rb:268:in `block in load'
/home/abhay/.rvm/gems/ruby-2.3.0/gems/activesupport-4.2.7.1/lib/active_support/dependencies.rb:240:in `load_dependency'
/home/abhay/.rvm/gems/ruby-2.3.0/gems/activesupport-4.2.7.1/lib/active_support/dependencies.rb:268:in `load'
-e:1:in `<main>'

There is a redundant `end` statement present at test/models/nics/managed_test.rb:103 in the foreman code


Related issues

Related to Foreman - Bug #16935: updating a NIC's "Device identifier" if it doesn't already have one fails if the "Device identifier" includes a . or :Closed2016-10-14

Associated revisions

Revision ee7d140f (diff)
Added by Abhay Kadam almost 2 years ago

Fixes #17494 - Remove stray end statement

Revision b25c6055 (diff)
Added by Abhay Kadam almost 2 years ago

Fixes #17494 - Remove stray end statement

(cherry picked from commit ee7d140fc79270de428d9bbe722360a89bf8afde)

History

#1 Updated by The Foreman Bot almost 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4057 added

#2 Updated by Abhay Kadam almost 2 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal almost 2 years ago

  • Related to Bug #16935: updating a NIC's "Device identifier" if it doesn't already have one fails if the "Device identifier" includes a . or : added

#4 Updated by Dominic Cleal almost 2 years ago

  • Legacy Backlogs Release (now unused) set to 189

Also available in: Atom PDF