Project

General

Profile

Refactor #17571

The foreman tools js module could be refactored to take advantage of some ES6 features

Added by Tomer Brisker over 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Associated revisions

Revision 9a082a8b (diff)
Added by Tomer Brisker over 3 years ago

Fixes #17571 - Refactor tfm.tools to use ES6 syntax

This also extracts the inherited user roles function to a sepereate
module, adds tests and refactors it. These changes also fix two other
issues:
1. a possible stored XSS in usergroup names,
2. tooltips on tables were broken (due to => syntax not changing `this`)

Revision 0bae8cc5 (diff)
Added by Tomer Brisker over 3 years ago

Fixes #17571 - Refactor tfm.tools to use ES6 syntax

This also extracts the inherited user roles function to a sepereate
module, adds tests and refactors it. These changes also fix two other
issues:
1. a possible stored XSS in usergroup names,
2. tooltips on tables were broken (due to => syntax not changing `this`)
(cherry picked from commit 9a082a8bfe273e4659403d2886d934075ba72fa9)

History

#1 Updated by The Foreman Bot over 3 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4081 added

#2 Updated by Anonymous over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal over 3 years ago

  • Legacy Backlogs Release (now unused) set to 189

#4 Updated by Daniel Lobato Garcia over 3 years ago

  • Target version set to 1.4.3

Also available in: Atom PDF