Project

General

Profile

Bug #17636

Template preview requires token to be present for template proxying

Added by Lukas Zapletal over 2 years ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Category:
Templates
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Basically I fixed #14479 only in lib/foreman/renderer.rb while we have another copy in app/models/concerns/host_template_helpers.rb. Preview and real template rendering give different results at the moment.

Ideal solution is to refactor this, but we have a separate ticket for that: #8290.


Related issues

Related to Foreman - Bug #14479: Function foreman_url check for tokensClosed2016-04-05
Related to Foreman - Bug #8290: dry the foreman_url logic that exists in both renderer and host_templates_helperClosed2014-11-05

Associated revisions

Revision c4ca7740 (diff)
Added by Lukas Zapletal over 2 years ago

Fixes #17636 - token no longer needed for proxied preview

Revision f7e49fb3 (diff)
Added by Lukas Zapletal over 2 years ago

Fixes #17636 - token no longer needed for proxied preview

(cherry picked from commit c4ca77400356ecc01737935cb6254934745fac6e)

History

#1 Updated by Lukas Zapletal over 2 years ago

  • Related to Bug #14479: Function foreman_url check for tokens added

#2 Updated by Lukas Zapletal over 2 years ago

  • Description updated (diff)

#3 Updated by Lukas Zapletal over 2 years ago

  • Related to Bug #8290: dry the foreman_url logic that exists in both renderer and host_templates_helper added

#4 Updated by The Foreman Bot over 2 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Lukas Zapletal
  • Pull request https://github.com/theforeman/foreman/pull/4103 added

#5 Updated by Daniel Lobato Garcia over 2 years ago

  • Target version set to 1.4.3

#6 Updated by Lukas Zapletal over 2 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#7 Updated by Dominic Cleal over 2 years ago

  • Legacy Backlogs Release (now unused) set to 210

#8 Updated by Lukas Zapletal over 2 years ago

  • Bugzilla link set to 1404582

#9 Updated by Daniel Lobato Garcia over 2 years ago

  • Target version changed from 1.4.3 to 1.15.5

Also available in: Atom PDF