Project

General

Profile

Actions
Copy link

Bug #17636

closed

Template preview requires token to be present for template proxying

Added by Lukas Zapletal about 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Lukas Zapletal
Category:
Templates
Target version:
1.14.1
Difficulty:
Triaged:
Bugzilla link:
1404582
Pull request:
https://github.com/theforeman/foreman/pull/4103
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Basically I fixed #14479 only in lib/foreman/renderer.rb while we have another copy in app/models/concerns/host_template_helpers.rb. Preview and real template rendering give different results at the moment.

Ideal solution is to refactor this, but we have a separate ticket for that: #8290.

Related issues 2 (0 open — 2 closed)

Related to Foreman - Bug #14479: Function foreman_url check for tokensClosedLukas Zapletal04/05/2016Actions
Related to Foreman - Bug #8290: dry the foreman_url logic that exists in both renderer and host_templates_helperClosedTimo Goebel11/05/2014Actions
Actions
Copy link
 #1

Updated by Lukas Zapletal about 8 years ago

  • Related to Bug #14479: Function foreman_url check for tokens added
Actions
Copy link
 #2

Updated by Lukas Zapletal about 8 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Lukas Zapletal about 8 years ago

  • Related to Bug #8290: dry the foreman_url logic that exists in both renderer and host_templates_helper added
Actions
Copy link
 #4

Updated by The Foreman Bot about 8 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Lukas Zapletal
  • Pull request https://github.com/theforeman/foreman/pull/4103 added
Actions
Copy link
 #5

Updated by Daniel Lobato Garcia about 8 years ago

  • Target version set to 1.4.3
Actions
Copy link
 #6

Updated by Lukas Zapletal about 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #7

Updated by Dominic Cleal about 8 years ago

  • Translation missing: en.field_release set to 210
Actions
Copy link
 #8

Updated by Lukas Zapletal about 8 years ago

  • Bugzilla link set to 1404582
Actions
Copy link
 #9

Updated by Daniel Lobato Garcia about 8 years ago

  • Target version changed from 1.4.3 to 1.15.5
Actions
Copy link

Also available in: Atom PDF