Project

General

Profile

Actions

Bug #17671

closed

German translation of the validation error is not correct

Added by Martin Bacovsky over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Category:
Hammer core
Fixed in Releases:
Found in Releases:
In Kanboard:

Description

Note in the output that the German locale doesn't match the others

$ LANG=DE hm domain create --name test.com --organization-ids='1,"3,4""'
>Domain konnte nicht erstellt werden<:
  invalid value for Float(): "Unclosed quoted field." 
$ LANG=FR hm domain create --name test.com --organization-ids='1,"3,4""'
>Impossible de créer le domaine<:
  >Erreur : >L'option '--organization-ids': Unclosed quoted field.<<

  >Voir : 'hammer domain create --help'<
$ hm domain create --name test.com --organization-ids='1,"3,4""'
>Could not create the domain<:
  >Error: >option '--organization-ids': Unclosed quoted field.<<

  >See: 'hammer domain create --help'<

Actions #1

Updated by Dominic Cleal over 7 years ago

I can't reproduce this:

13:18 $ LANG=DE be hammer domain create --name test.com --organization-ids='1,"3,4""'
>Domain konnte nicht erstellt werden<:
  >Fehler: >Unbekannte Option '--organization-ids'<<

  >Siehe: 'hammer domain create --help'<
✘-64 ~/code/foreman/hammer-cli-foreman [master|…1] 
13:18 $ LANG=FR be hammer domain create --name test.com --organization-ids='1,"3,4""'
>Impossible de créer le domaine<:
  >Erreur : >Option inconnue '--organization-ids'<<

  >Voir : 'hammer domain create --help'<
✘-64 ~/code/foreman/hammer-cli-foreman [master|…1] 

It sounds like an error in the translation (e.g. wrong % code or something), but I don't see any errors.

Actions #2

Updated by Dominic Cleal over 7 years ago

Sorry, I can reproduce it when using https://github.com/theforeman/hammer-cli/pull/226.

Actions #3

Updated by Tomáš Strachota over 7 years ago

Closer investigation showed there's following typo:

msgid "option '%<switch>s': %<message>s" 
msgstr "Option '%<switch>s': %<message>en" 

Two more translations are probably affected with the same typ:

msgid "parameter '%<param>s': %<message>s" 
msgstr "Parameter '%<param>s': %<message>en" 

msgid "%<env>s: %<message>s" 
msgstr "%<env>s: %<message>en" 

Actions #4

Updated by Tomáš Strachota over 7 years ago

I updated the messages in transifex but now I'm unable to pull them. Not sure why, but when doing 'make tx-update' the changes remain in hammer-cli.edit.po and hammer-cli.po remains untouched.

Actions #5

Updated by Anonymous almost 7 years ago

what's the status here?

Actions #6

Updated by The Foreman Bot almost 7 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Tomáš Strachota
  • Pull request https://github.com/theforeman/hammer-cli/pull/243 added
Actions #7

Updated by Tomáš Strachota almost 7 years ago

  • Assignee deleted (Tomáš Strachota)

I found out there are were issues with merging edit.po int .po files in Makefile so the fixed translation was never merged. Most of hammer plugins is probably affected as well.

Actions #8

Updated by The Foreman Bot almost 7 years ago

  • Assignee set to Tomáš Strachota
Actions #9

Updated by The Foreman Bot almost 7 years ago

  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/311 added
Actions #10

Updated by Anonymous almost 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #11

Updated by Tomáš Strachota over 6 years ago

  • translation missing: en.field_release set to 243
Actions

Also available in: Atom PDF