Bug #17671: German translation of the validation error is not correct - Hammer CLI - Foreman

Actions

Copy link

Bug #17671

closed

German translation of the validation error is not correct

Added by Martin Bacovsky about 8 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Tomáš Strachota

Category:

Hammer core

Target version:

hammer-cli-foreman-0.11.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/hammer-cli/pull/243, https://github.com/theforeman/hammer-cli-foreman/pull/311

Team Backlog:

Fixed in Releases:

Found in Releases:

Foreman - Nightly

In Kanboard:

Red Hat JIRA:

Description

Note in the output that the German locale doesn't match the others

$ LANG=DE hm domain create --name test.com --organization-ids='1,"3,4""'
>Domain konnte nicht erstellt werden<:
  invalid value for Float(): "Unclosed quoted field." 
$ LANG=FR hm domain create --name test.com --organization-ids='1,"3,4""'
>Impossible de créer le domaine<:
  >Erreur : >L'option '--organization-ids': Unclosed quoted field.<<

  >Voir : 'hammer domain create --help'<
$ hm domain create --name test.com --organization-ids='1,"3,4""'
>Could not create the domain<:
  >Error: >option '--organization-ids': Unclosed quoted field.<<

  >See: 'hammer domain create --help'<

Actions

Copy link

Updated by Dominic Cleal about 8 years ago

I can't reproduce this:

13:18 $ LANG=DE be hammer domain create --name test.com --organization-ids='1,"3,4""'
>Domain konnte nicht erstellt werden<:
  >Fehler: >Unbekannte Option '--organization-ids'<<

  >Siehe: 'hammer domain create --help'<
✘-64 ~/code/foreman/hammer-cli-foreman [master|…1] 
13:18 $ LANG=FR be hammer domain create --name test.com --organization-ids='1,"3,4""'
>Impossible de créer le domaine<:
  >Erreur : >Option inconnue '--organization-ids'<<

  >Voir : 'hammer domain create --help'<
✘-64 ~/code/foreman/hammer-cli-foreman [master|…1]

It sounds like an error in the translation (e.g. wrong % code or something), but I don't see any errors.

Actions

Copy link

Updated by Dominic Cleal about 8 years ago

Sorry, I can reproduce it when using https://github.com/theforeman/hammer-cli/pull/226.

Actions

Copy link

Updated by Tomáš Strachota about 8 years ago

Closer investigation showed there's following typo:

msgid "option '%<switch>s': %<message>s" 
msgstr "Option '%<switch>s': %<message>en"

Two more translations are probably affected with the same typ:

msgid "parameter '%<param>s': %<message>s" 
msgstr "Parameter '%<param>s': %<message>en" 

msgid "%<env>s: %<message>s" 
msgstr "%<env>s: %<message>en"

Actions

Copy link

Updated by Tomáš Strachota about 8 years ago

I updated the messages in transifex but now I'm unable to pull them. Not sure why, but when doing 'make tx-update' the changes remain in hammer-cli.edit.po and hammer-cli.po remains untouched.

Actions

Copy link

Updated by Anonymous over 7 years ago

what's the status here?

Actions

Copy link

Updated by The Foreman Bot over 7 years ago

Status changed from New to Ready For Testing
Assignee set to Tomáš Strachota
Pull request https://github.com/theforeman/hammer-cli/pull/243 added

Actions

Copy link

Updated by Tomáš Strachota over 7 years ago

Assignee deleted (~~Tomáš Strachota~~)

I found out there are were issues with merging edit.po int .po files in Makefile so the fixed translation was never merged. Most of hammer plugins is probably affected as well.

Actions

Copy link