Project

General

Profile

Refactor #17906

Move create_*_record remove_*_record functions into dns_common

Added by Ewoud Kohl van Wijngaarden almost 4 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Category:
DNS
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Currently most of the DNS providers implement the exact same create_*_record and remove_*_record functions, but with a different do_create and do_remoe implementation. This leads to duplication and extra maintenance effort. Providing them by default in dns_common should reduce this and make plugin development easier.


Related issues

Related to Smart Proxy - Feature #17879: Add DNS CNAME entry for nsupdateResolved2016-12-29

Associated revisions

Revision 47732b9e (diff)
Added by Ewoud Kohl van Wijngaarden almost 4 years ago

Fixes #17906 - Move {create,remove}_*_record to dns_common

Before most DNS providers had pretty much exact copies of these
functions. This removes duplication and allows for much simpler plugins.

In doing so it also fixes #17879 by adding CNAME support to the nsupdate
module.

Lastly it fixes some require statements to allow running single tests
rather than relying on other tests to do their requirements for them.

History

#1 Updated by Ewoud Kohl van Wijngaarden almost 4 years ago

  • Category set to DNS
  • Status changed from New to Assigned
  • Assignee set to Ewoud Kohl van Wijngaarden

#2 Updated by The Foreman Bot almost 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/492 added

#3 Updated by Dmitri Dolguikh almost 4 years ago

#4 Updated by Anonymous almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Dominic Cleal almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 209

Also available in: Atom PDF