Project

General

Profile

Actions
Copy link

Bug #17967

closed

show_diff disabled in 1.0.6, should be enabled

Added by Dominic Cleal almost 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Dominic Cleal
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/kafo/pull/202
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Prior to kafo 1.0.6, Puppet's show_diff option was enabled and the log would show a diff of any files modified. Since #17504, the configuration option has been set to false (erroneously) and the log no longer shows diffs for file changes.

now false: https://github.com/theforeman/kafo/commit/88f99aeb6a963d7856d82c5b7f0f11d10e00c9d4#diff-657b82e4fb9c80f11badef608b14de10R421
previously: https://github.com/theforeman/kafo/commit/88f99aeb6a963d7856d82c5b7f0f11d10e00c9d4#diff-657b82e4fb9c80f11badef608b14de10L421

Related issues 1 (0 open — 1 closed)

Related to Kafo - Bug #17504: Can't run foreman-installer: Could not find class ::foreman::paramsClosedDominic Cleal11/28/2016Actions
Actions
Copy link
 #1

Updated by The Foreman Bot almost 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/kafo/pull/202 added
Actions
Copy link
 #2

Updated by Dominic Cleal almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Dominic Cleal almost 8 years ago

  • Related to Bug #17504: Can't run foreman-installer: Could not find class ::foreman::params added
Actions
Copy link

Also available in: Atom PDF