Project

General

Profile

Actions
Copy link

Refactor #17972

closed

Trends JS is overly complicated, form & helper are outdated and inefficient

Added by Tomer Brisker over 7 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Tomer Brisker
Category:
Trends
Target version:
1.15.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4162, https://github.com/theforeman/foreman/pull/4184
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

JS code is way too complex, the form and its helpers are only used for new trends but still check if this is a new trend and are inefficient in general.

Related issues 2 (1 open — 1 closed)

Related to Foreman - Bug #18033: unable to create a new trendRejected01/11/2017Actions
Related to Foreman - Task #23451: move all javascript/css assets to webpackNew04/30/2018Actions
Actions
Copy link
 #1

Updated by The Foreman Bot over 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4162 added
Actions
Copy link
 #2

Updated by Anonymous over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Dominic Cleal over 7 years ago

  • translation missing: en.field_release set to 209
Actions
Copy link
 #4

Updated by Ohad Levy over 7 years ago

  • Related to Bug #18033: unable to create a new trend added
Actions
Copy link
 #5

Updated by The Foreman Bot over 7 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4184 added
Actions
Copy link
 #6

Updated by Daniel Lobato Garcia about 7 years ago

  • Target version set to 169
Actions
Copy link
 #7

Updated by Brad Buckingham about 7 years ago

  • Target version deleted (169)
Actions
Copy link
 #8

Updated by Daniel Lobato Garcia about 7 years ago

  • Target version set to 1.11.0
Actions
Copy link
 #9

Updated by Ohad Levy almost 6 years ago

  • Related to Task #23451: move all javascript/css assets to webpack added
Actions
Copy link

Also available in: Atom PDF