Project

General

Profile

Refactor #17972

Trends JS is overly complicated, form & helper are outdated and inefficient

Added by Tomer Brisker almost 4 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Tomer Brisker
Category:
Trends
Target version:
1.15.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4184, https://github.com/theforeman/foreman/pull/4162
Fixed in Releases:
Found in Releases:

Description

JS code is way too complex, the form and its helpers are only used for new trends but still check if this is a new trend and are inefficient in general.

Related issues

Related to Foreman - Bug #18033: unable to create a new trendRejected2017-01-11
Related to Foreman - Task #23451: move all javascript/css assets to webpackNew2018-04-30

Associated revisions

Revision 1d7dcde3 (diff)
Added by Tomer Brisker almost 4 years ago

Fixes #17972 - Simplify new trend form js and helpers

Migrated the js to webpack as well.

Revision 77110ce3 (diff)
Added by Tomer Brisker almost 4 years ago

Refs #17972 - remove trends.js from assets initializer

History

#1 Updated by The Foreman Bot almost 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4162 added

#2 Updated by Anonymous almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 209

#4 Updated by Ohad Levy almost 4 years ago

  • Related to Bug #18033: unable to create a new trend added

#5 Updated by The Foreman Bot almost 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4184 added

#6 Updated by Daniel Lobato Garcia almost 4 years ago

  • Target version set to 169

#7 Updated by Brad Buckingham over 3 years ago

  • Target version deleted (169)

#8 Updated by Daniel Lobato Garcia over 3 years ago

  • Target version set to 1.11.0

#9 Updated by Ohad Levy over 2 years ago

  • Related to Task #23451: move all javascript/css assets to webpack added

Also available in: Atom PDF