Project

General

Profile

Actions

Refactor #17972

closed

Trends JS is overly complicated, form & helper are outdated and inefficient

Added by Tomer Brisker almost 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Trends
Target version:
Fixed in Releases:
Found in Releases:

Description

JS code is way too complex, the form and its helpers are only used for new trends but still check if this is a new trend and are inefficient in general.


Related issues 2 (1 open1 closed)

Related to Foreman - Bug #18033: unable to create a new trendRejected01/11/2017Actions
Related to Foreman - Task #23451: move all javascript/css assets to webpackNew04/30/2018Actions
Actions #1

Updated by The Foreman Bot almost 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4162 added
Actions #2

Updated by Anonymous almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #3

Updated by Dominic Cleal almost 8 years ago

  • Translation missing: en.field_release set to 209
Actions #4

Updated by Ohad Levy almost 8 years ago

  • Related to Bug #18033: unable to create a new trend added
Actions #5

Updated by The Foreman Bot almost 8 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4184 added
Actions #6

Updated by Daniel Lobato Garcia almost 8 years ago

  • Target version set to 169
Actions #7

Updated by Brad Buckingham almost 8 years ago

  • Target version deleted (169)
Actions #8

Updated by Daniel Lobato Garcia almost 8 years ago

  • Target version set to 1.11.0
Actions #9

Updated by Ohad Levy over 6 years ago

  • Related to Task #23451: move all javascript/css assets to webpack added
Actions

Also available in: Atom PDF