Project

General

Profile

Actions

Feature #1799

closed

Respect HTTP_X_FORWARDED_FOR for configured list of ip addresses.

Added by Steve Traylen over 12 years ago. Updated over 12 years ago.

Status:
Closed
Priority:
Normal
Category:
Unattended installations
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Hi
app/controllers/unattended_controller.rb

contains:

elsif (ip = request.env['REMOTE_ADDR']) =~ /127.0.0/
      ip = request.env["HTTP_X_FORWARDED_FOR"] unless request.env["HTTP_X_FORWARDED_FOR"].nil?
end

i.e if connecting from localhost then respect the HTTP_X_FORWARDED_FOR for requests for e.g.
http://judy.cern.ch/unattended/built

Having set up a remote http load balencer in front of two foreman hosts this 127.0.0 needs to be configured to whatever
that remote host is. After editing unattended_controller.rb to contain my balencers ip address the unattended scripts
work as expected.


Related issues 1 (1 open0 closed)

Related to Foreman - Bug #21628: Using the setting "Update IP from built request" when building host through proxy, the IP will be updated with the proxy instead of the host IPNew11/10/2017Actions
Actions #1

Updated by Ohad Levy over 12 years ago

what would you like we change? make it as a setting? or always respect the forwarded ip header?

Actions #2

Updated by Ohad Levy over 12 years ago

  • Target version set to 1.1
Actions #3

Updated by Ohad Levy over 12 years ago

  • Assignee changed from Ohad Levy to Hannes Schaller
Actions #4

Updated by Hannes Schaller over 12 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100
Actions #5

Updated by Ivan Necas about 7 years ago

  • Related to Bug #21628: Using the setting "Update IP from built request" when building host through proxy, the IP will be updated with the proxy instead of the host IP added
Actions

Also available in: Atom PDF