Project

General

Profile

Bug #18132

foreman-installer -v --scenario katello --noop deletes pulp.conf

Added by Klaas D over 4 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Installer
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Hi,
I ran foreman-installer -v --scenario katello --noop to check for configuration changes after upgrading to puppet4. The noop mode is not passed to the hooks and therefore deletes the pulp.conf in https://github.com/Katello/katello-installer/blob/master/hooks/pre/29-remove_package_httpd_conf.rb then it doesn't get created during kafo installer because its run in noop mode and then afterwards its created with a comment by https://github.com/Katello/katello-installer/blob/master/hooks/post/29-create_package_httpd_conf.rb

I'm not sure where the correct fix would be, my guess is the hooks need to be made aware of noop mode.

Greetings
Klaas

Associated revisions

Revision e1c00d97 (diff)
Added by Klaas Demter over 4 years ago

fixes #18132 - hooks in --noop delete pulp.conf (#468)

this workaround is only needed for smart proxies, main katello
overwrites the pulp.conf. Noop check added to both hooks.

History

#1 Updated by Klaas D over 4 years ago

  • Assignee set to Klaas D

I'll try to make the hooks noop aware :)

#2 Updated by The Foreman Bot over 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello-installer/pull/468 added

#3 Updated by Klaas D over 4 years ago

katello now uses the pulp.conf instead of 05-pulps-https.conf. therefore it doesn't need to delete or create pulp.conf in hook because it overwrites pulp.conf within the
installer

#4 Updated by Stephen Benjamin over 4 years ago

  • Bugzilla link set to 1414780

We actually only use pulp.conf on a Katello. A proxy with pulp doesn't, so we still need the code, just a check to make sure it doesn't run on the main katello (and also not in noop mode).

#5 Updated by Anonymous over 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by Justin Sherrill over 4 years ago

  • Legacy Backlogs Release (now unused) set to 188

Also available in: Atom PDF