Bug #18132
closed
foreman-installer -v --scenario katello --noop deletes pulp.conf
Description
Hi,
I ran foreman-installer -v --scenario katello --noop to check for configuration changes after upgrading to puppet4. The noop mode is not passed to the hooks and therefore deletes the pulp.conf in https://github.com/Katello/katello-installer/blob/master/hooks/pre/29-remove_package_httpd_conf.rb then it doesn't get created during kafo installer because its run in noop mode and then afterwards its created with a comment by https://github.com/Katello/katello-installer/blob/master/hooks/post/29-create_package_httpd_conf.rb
I'm not sure where the correct fix would be, my guess is the hooks need to be made aware of noop mode.
Greetings
Klaas
Updated by Klaas D almost 8 years ago
- Assignee set to Klaas D
I'll try to make the hooks noop aware :)
Updated by The Foreman Bot almost 8 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/Katello/katello-installer/pull/468 added
Updated by Klaas D almost 8 years ago
katello now uses the pulp.conf instead of 05-pulps-https.conf. therefore it doesn't need to delete or create pulp.conf in hook because it overwrites pulp.conf within the
installer
Updated by Stephen Benjamin almost 8 years ago
- Bugzilla link set to 1414780
We actually only use pulp.conf on a Katello. A proxy with pulp doesn't, so we still need the code, just a check to make sure it doesn't run on the main katello (and also not in noop mode).
Updated by Anonymous almost 8 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset katello-installer|e1c00d97adbba419140b50b65b2458ea0cda3be9.
Updated by Justin Sherrill almost 8 years ago
- Translation missing: en.field_release set to 188
Updated by Klaas D over 7 years ago
- Translation missing: en.field_release changed from 188 to 219