Project

General

Profile

Bug #18177

The autosign checker does not close its file descriptor

Added by Paul Kelly over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Paul Kelly
Category:
Puppet
Target version:
-
Difficulty:
trivial
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/smart-proxy/pull/497, https://github.com/theforeman/smart-proxy/pull/522
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Over a period of time lsof shows that the autosign.conf file is being opened repeatedly but not closed.

I am working with a very old code base but the fault is still there in development.

Associated revisions

Revision 538faca7 (diff)
Added by Paul Kelly over 2 years ago

fixes #18177 - file descriptor leak in puppet autosign handling

History

#1 Updated by The Foreman Bot over 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/497 added

#2 Updated by Dmitri Dolguikh over 2 years ago

This looks like the culprit: https://github.com/theforeman/smart-proxy/blob/develop/modules/puppetca/puppetca_main.rb#L25. But there are a couple more places where file descriptors will be leaked should an error occur.

#3 Updated by The Foreman Bot over 2 years ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/522 added

#4 Updated by Paul Kelly over 2 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF