Bug #18210: Libvirt provider fails to set DHCP nametag when record doesn't have name field - Smart Proxy - Foreman

Actions

Copy link

Bug #18210

closed

Libvirt provider fails to set DHCP nametag when record doesn't have name field

Added by Daniel Lobato Garcia over 7 years ago. Updated over 7 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Daniel Lobato Garcia

Category:

DHCP

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/smart-proxy/pull/500

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

To set the nametag we call record.name, which might not be available.
In such a case, record.name fails with

] pry(#<Proxy::DHCP::Libvirt::LibvirtDHCPNetwork>)> record.name
#NoMethodError: undefined method `name' for #<Proxy::DHCP::Lease:0x005654f2c66798>
#from (pry):5:in `del_dhcp_record'

and the entire deletion fails. It should not call .name if it's not there.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by The Foreman Bot over 7 years ago

Status changed from New to Ready For Testing
Assignee set to Daniel Lobato Garcia
Pull request https://github.com/theforeman/smart-proxy/pull/500 added

Actions

Copy link

Updated by Anonymous over 7 years ago

Related to Bug #18070: When adding a new dhcp reservation, ip and mac addresses should be checked not only against existing reservations but leases as well added

Actions

Copy link