Project

General

Profile

Bug #18227

Snippet with variables does not reset @vars after they finish in unsafe mode

Added by Marek Hulán almost 5 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Templates
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

If we have a template such as

<%= snippet 'test', :variables => { :var => 'value' }
<%= @var %>

the @var would be set by the template which can cause problems later. This only happens in unsafe mode where we use the same context for each rendering. We need to split local context variables and reset them after this local context is rendered.


Related issues

Related to Foreman - Feature #18143: Snippet macros should support passing variablesClosed2017-01-18

Associated revisions

Revision e7603faf (diff)
Added by Marek Hulán over 4 years ago

Fixes #18227 - clean up variables after rendering

History

#1 Updated by Marek Hulán almost 5 years ago

  • Related to Feature #18143: Snippet macros should support passing variables added

#2 Updated by The Foreman Bot almost 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4222 added

#3 Updated by Marek Hulán over 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal over 4 years ago

  • Legacy Backlogs Release (now unused) set to 209

Also available in: Atom PDF