Project

General

Profile

Actions
Copy link

Refactor #18232

closed

Add phantomjs-prebuilt dev dependency for integration tests

Added by Dominic Cleal over 8 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Dominic Cleal
Category:
Packaging
Target version:
1.15.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4225, https://github.com/theforeman/foreman/pull/4235
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Integration tests using JavaScript depend on using phantomjs via poltergeist, but there is no explicit gem dependency to install phantomjs, instead requiring manual installation.

The phantomjs-prebuilt npm package should be added to development dependencies, so it can be installed automatically.

Actions
Copy link
 #1

Updated by The Foreman Bot over 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4225 added
Actions
Copy link
 #2

Updated by Dominic Cleal over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Dominic Cleal over 8 years ago

  • Translation missing: en.field_release set to 209
Actions
Copy link
 #4

Updated by The Foreman Bot over 8 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4235 added
Actions
Copy link

Also available in: Atom PDF