Project

General

Profile

Refactor #18232

Add phantomjs-prebuilt dev dependency for integration tests

Added by Dominic Cleal over 5 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Dominic Cleal
Category:
Packaging
Target version:
1.15.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4235, https://github.com/theforeman/foreman/pull/4225
Fixed in Releases:
Found in Releases:

Description

Integration tests using JavaScript depend on using phantomjs via poltergeist, but there is no explicit gem dependency to install phantomjs, instead requiring manual installation.

The phantomjs-prebuilt npm package should be added to development dependencies, so it can be installed automatically.

Associated revisions

Revision 2e81c25e (diff)
Added by Dominic Cleal over 5 years ago

fixes #18232 - install phantomjs via npm

Revision 6d3fcf09 (diff)
Added by Dominic Cleal over 5 years ago

refs #18232 - make phantomjs optional, not available on all archs

History

#1 Updated by The Foreman Bot over 5 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4225 added

#2 Updated by Dominic Cleal over 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal over 5 years ago

  • Legacy Backlogs Release (now unused) set to 209

#4 Updated by The Foreman Bot over 5 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4235 added

Also available in: Atom PDF