Project

General

Profile

Actions

Refactor #18232

closed

Add phantomjs-prebuilt dev dependency for integration tests

Added by Dominic Cleal about 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Packaging
Target version:
Fixed in Releases:
Found in Releases:

Description

Integration tests using JavaScript depend on using phantomjs via poltergeist, but there is no explicit gem dependency to install phantomjs, instead requiring manual installation.

The phantomjs-prebuilt npm package should be added to development dependencies, so it can be installed automatically.

Actions #1

Updated by The Foreman Bot about 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4225 added
Actions #2

Updated by Dominic Cleal about 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #3

Updated by Dominic Cleal about 7 years ago

  • translation missing: en.field_release set to 209
Actions #4

Updated by The Foreman Bot about 7 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4235 added
Actions

Also available in: Atom PDF