Bug #18366: vSphere: exception raised when vm cannot be created correctly - Foreman

Bug #18366

vSphere: exception raised when vm cannot be created correctly

Added by Timo Goebel about 6 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Timo Goebel

Category:

Compute resources - VMware

Target version:

1.14.2

Difficulty:

trivial

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/4249

Fixed in Releases:

Found in Releases:

1.13.2

Red Hat JIRA:

Description

NoMethodError: undefined method `include?' for nil:NilClass | /opt/theforeman/tfm/root/usr/share/gems/gems/fog-vsphere-1.0.0/lib/fog/vsphere/requests/compute/get_virtual_machine.rb:40:in `get_vm_by_name' | /opt/theforeman/tfm/root/usr/share/gems/gems/fog-vsphere-1.0.0/lib/fog/vsphere/requests/compute/get_virtual_machine.rb:25:in `block in get_vm_ref' | /opt/theforeman/tfm/root/usr/share/gems/gems/fog-vsphere-1.0.0/lib/fog/vsphere/requests/compute/get_virtual_machine.rb:25:in `map' | /opt/theforeman/tfm/root/usr/share/gems/gems/fog-vsphere-1.0.0/lib/fog/vsphere/requests/compute/get_virtual_machine.rb:25:in `get_vm_ref' | /opt/theforeman/tfm/root/usr/share/gems/gems/fog-vsphere-1.0.0/lib/fog/vsphere/requests/compute/get_virtual_machine.rb:7:in `get_virtual_machine' | /opt/theforeman/tfm/root/usr/share/gems/gems/fog-vsphere-1.0.0/lib/fog/vsphere/models/compute/servers.rb:31:in `get' | /usr/share/foreman/app/models/compute_resource.rb:169:in `find_vm_by_uuid' | /usr/share/foreman/app/models/compute_resource.rb:187:in `destroy_vm' | /usr/share/foreman/app/models/compute_resources/foreman/model/vmware.rb:399:in `rescue in create_vm' | /usr/share/foreman/app/models/compute_resources/foreman/model/vmware.rb:386:in `create_vm' | /usr/share/foreman/app/models/concerns/orchestration/compute.rb:82:in `setCompute'

rescue block in create_vm should check if vm.id is not nil