Project

General

Profile

Feature #18638

Add SCSS webpack support

Added by matan werbner over 5 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
matan werbner
Category:
JavaScript stack
Target version:
1.15.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4334
Fixed in Releases:
Found in Releases:

Related issues

Related to Foreman - Bug #18688: sass-loader dep has a peer dependency on webpack 2.x, not 1.xClosed2017-02-27
Related to Foreman - Bug #18716: Fix storybook to work with scssClosed2017-02-28

Associated revisions

Revision 2a824da7 (diff)
Added by matan over 5 years ago

Fixes #18638 - add sass support to webpack

Revision a2764da5 (diff)
Added by Dominic Cleal over 5 years ago

refs #18638 - use node-sass, sass-loader

History

#1 Updated by Ohad Levy over 5 years ago

can you please provide context? what is this about?

#2 Updated by matan werbner over 5 years ago

Ohad Levy wrote:

can you please provide context? what is this about?

i would like to be able to use .scss files as part of react components.

to do that, some changes need to be made to webpack, and possibly ruby rendering the css bundle.

#3 Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4321 added

#4 Updated by The Foreman Bot over 5 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4334 added

#5 Updated by Ohad Levy over 5 years ago

  • Subject changed from Feature - suport sass in the client side to Add SCSS webpack support
  • Pull request deleted (https://github.com/theforeman/foreman/pull/4321)

#6 Updated by Anonymous over 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#7 Updated by Dominic Cleal over 5 years ago

  • Related to Bug #18688: sass-loader dep has a peer dependency on webpack 2.x, not 1.x added

#8 Updated by Dominic Cleal over 5 years ago

  • Category set to JavaScript stack
  • Legacy Backlogs Release (now unused) set to 209

#9 Updated by Dominic Cleal over 5 years ago

  • Related to Bug #18716: Fix storybook to work with scss added

Also available in: Atom PDF