Project

General

Custom queries

Profile

Actions
Copy link

Refactor #18665

closed

Foreman::Controller::Parameters tests should ignore hash/AC::Parameters differences

Added by Dominic Cleal about 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Low
Assignee:
Dominic Cleal
Category:
Tests
Target version:
1.15.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4333
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Under Rails 5.0, the ActionController::Parameters class no longer inherits from Hash and is now its own class that delegates some methods to an internal Hash.

This causes failures in tests for the Foreman::Controller::Parameters::* concerns which have equality assertions on AC::Parameters and hashes, to check the expected filtered output, e.g.

--- expected
+++ actual
@@ -1 +1 @@
-{"plugin_ext"=>"b"}
+<ActionController::Parameters {"plugin_ext"=>"b"} permitted: true>

AC::Parameters has a #to_h method that returns a hash (in both 4.2 and 5.0), so these tests can trivially be updated to call #to_h before comparing the filtered object to a hash.

Added by Dominic Cleal about 8 years ago

Revision 0a54c7f8 (diff)

fixes #18665 - call #to_h before comparing AC::Parameters to hash

Allows comparisons when ActionController::Parameters is separated from
Hash in Rails 5.0. #permit! is now called on inner hashes sent through
KeepParam (similar to rails/rails@e86524c in 5.1) so they are included
in the #to_h permitted output.

Actions
Copy link

Also available in: Atom PDF