Project

General

Profile

Actions

Bug #18678

closed

notification actions always open an external tab

Added by Ohad Levy over 7 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Notifications
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

https://github.com/theforeman/foreman/blob/develop/webpack/assets/javascripts/react_app/components/notifications/NotificationDropdown.js#L9 hard code to always Opens the linked document in a new window or tab, it should be configurable.

additionally, clicking on an action should close the notification drawer.


Related issues 2 (0 open2 closed)

Related to Discovery - Feature #18677: add UI notifications on discovered host eventClosedOhad Levy02/26/2017Actions
Related to Foreman - Bug #18426: Provide support for Notification actionsClosedDaniel Lobato Garcia02/08/2017Actions
Actions #1

Updated by Ohad Levy over 7 years ago

  • Related to Feature #18677: add UI notifications on discovered host event added
Actions #2

Updated by Ohad Levy over 7 years ago

  • Related to Bug #18426: Provide support for Notification actions added
Actions #3

Updated by Gail Steiger over 7 years ago

IMHO, notification actions opening an external tab is a feature, not a bug.

Why should clicking an action close the notification drawer?

Actions #4

Updated by Ohad Levy over 7 years ago

Gail Steiger wrote:

IMHO, notification actions opening an external tab is a feature, not a bug.

if the link is within the app, i can't see how opening it in a new tab makes sense, i agree in some cases you want external urls, so we need both.

Why should clicking an action close the notification drawer?

for the case where i am redirected to another page within the app, i think it make sense to close the drawer (otherwise the first thing I'll do is to close it).

Actions #5

Updated by Liza Gilman over 7 years ago

  • Assignee set to Liza Gilman
Actions #6

Updated by The Foreman Bot over 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4403 added
Actions #7

Updated by The Foreman Bot over 7 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4401 added
Actions #8

Updated by matan werbner over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #9

Updated by Ohad Levy over 7 years ago

  • Assignee changed from Liza Gilman to matan werbner
  • Translation missing: en.field_release set to 209
  • Pull request deleted (https://github.com/theforeman/foreman/pull/4403)
Actions

Also available in: Atom PDF