Bug #18678
closed
notification actions always open an external tab
Description
https://github.com/theforeman/foreman/blob/develop/webpack/assets/javascripts/react_app/components/notifications/NotificationDropdown.js#L9 hard code to always Opens the linked document in a new window or tab, it should be configurable.
additionally, clicking on an action should close the notification drawer.
Updated by Ohad Levy about 7 years ago
- Related to Feature #18677: add UI notifications on discovered host event added
Updated by Ohad Levy about 7 years ago
- Related to Bug #18426: Provide support for Notification actions added
Updated by Gail Steiger about 7 years ago
IMHO, notification actions opening an external tab is a feature, not a bug.
Why should clicking an action close the notification drawer?
Updated by Ohad Levy about 7 years ago
Gail Steiger wrote:
IMHO, notification actions opening an external tab is a feature, not a bug.
if the link is within the app, i can't see how opening it in a new tab makes sense, i agree in some cases you want external urls, so we need both.
Why should clicking an action close the notification drawer?
for the case where i am redirected to another page within the app, i think it make sense to close the drawer (otherwise the first thing I'll do is to close it).
Updated by
Updated by The Foreman Bot about 7 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/4403 added
Updated by The Foreman Bot about 7 years ago
- Pull request https://github.com/theforeman/foreman/pull/4401 added
Updated by matan werbner about 7 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset a29d54389e9c00e55c7824e53fb407c9e3e206cd.
Updated by Ohad Levy about 7 years ago
- Assignee changed from Liza Gilman to matan werbner
- translation missing: en.field_release set to 209
- Pull request deleted (
https://github.com/theforeman/foreman/pull/4403)