Project

General

Profile

Bug #18688

sass-loader dep has a peer dependency on webpack 2.x, not 1.x

Added by Dominic Cleal over 4 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Packaging
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

sass-loader (as added in #18638) has a peer dependency on webpack ^2.0.0, but webpack 1.14.x is the latest permitted in package.json, causing installation errors:

npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "i" 
npm ERR! node v4.7.3
npm ERR! npm  v2.15.11
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package webpack@1.14.0 does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer extract-text-webpack-plugin@1.0.1 wants webpack@^1.9.11
npm ERR! peerinvalid Peer stats-webpack-plugin@0.2.2 wants webpack@^1.0
npm ERR! peerinvalid Peer webpack-dev-middleware@1.8.4 wants webpack@1 || ^2.1.0-beta
npm ERR! peerinvalid Peer webpack-dev-server@1.16.3 wants webpack@>=1.3.0 <3
npm ERR! peerinvalid Peer babel-loader@6.2.10 wants webpack@1 || 2 || ^2.1.0-beta || ^2.2.0-rc
npm ERR! peerinvalid Peer sass-loader@6.0.2 wants webpack@^2.0.0                                 # <-- here

Some newer npm versions appear to ignore the broken peer dep, but this is still likely to cause an issue.

npm WARN sass-loader@6.0.2 requires a peer of webpack@^2.0.0 but none was installed.

Related issues

Related to Foreman - Feature #18638: Add SCSS webpack supportClosed2017-02-23

Associated revisions

Revision 147aa4e5 (diff)
Added by Tomer Brisker over 4 years ago

Fixes #18688 - pin sass-loader to version supporting webpack 1

History

#1 Updated by Dominic Cleal over 4 years ago

  • Description updated (diff)

#2 Updated by Dominic Cleal over 4 years ago

#3 Updated by The Foreman Bot over 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Tomer Brisker
  • Pull request https://github.com/theforeman/foreman/pull/4342 added

#4 Updated by Anonymous over 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF