Project

General

Profile

Bug #187

Reserved chars in facts

Added by Dis Connect about 9 years ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Search
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Spaces break the query interface (fixed with Ohad's patch, below) but dash is still reserved:
gethosts({"fact"=>{"productname"=>"Not Specified"}})
- returns a host count
gethosts({"fact"=>{"ps"=>"ps -ef"}})
- returns a 500 error, generates a url like "http://puppet:3000/hosts/query?fact[]=ps-ps%20-ef&&format=yml"

Even with fixed regex there is still no way to query for fact "foo-bar", esp if there is also a fact "foo".

882601.diff 882601.diff 448 Bytes Patch to foreman.rb query library - Fix spaces in fact values Dis Connect, 03/23/2010 01:50 PM

Associated revisions

Revision 5539907c (diff)
Added by Ohad Levy about 9 years ago

fixes #187 - Reserved chars in facts

History

#1 Updated by Ohad Levy about 9 years ago

  • Category set to 19
  • Assignee set to Ohad Levy
  • Target version set to 0.1-5

#2 Updated by Ohad Levy about 9 years ago

  • Status changed from New to Ready For Testing
  • % Done changed from 0 to 100

#3 Updated by Dis Connect about 9 years ago

Looks good with my testcase:
irb(main):003:0> gethosts({"fact"=>{"ps"=>"ps -ef"}}).length
=> 183

Hopefully nobody uses separator anywhere tho :)

#4 Updated by Ohad Levy about 9 years ago

  • Status changed from Ready For Testing to Closed

#5 Updated by Tomer Brisker 7 months ago

  • Category changed from 19 to Search

Also available in: Atom PDF