Project

General

Profile

Refactor #18763

Change "Delete" button to standard style

Added by June Zhang over 5 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
June Zhang
Category:
Web Interface
Target version:
1.15.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4352
Fixed in Releases:
Found in Releases:

Description

Please reference this mail - https://groups.google.com/forum/?fromgroups#!topic/foreman-dev/Gx69q6ZRB3s
The delete button is not the standard style.

Associated revisions

Revision 4b2873a6 (diff)
Added by June Zhang over 5 years ago

Fixes #18763 - Change delete button to standard style

History

#1 Updated by Dominic Cleal over 5 years ago

  • Category set to Web Interface

Unclear what "standard" means here, the users delete button shown in that mailing list post looks identical to every other delete button to me.

#2 Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4352 added

#3 Updated by June Zhang over 5 years ago

We recommended to use the secondary button style for the delete button.
In PatternFly, the primary button is the bule button, the secondary button is the grey button, also is the default button.

#4 Updated by June Zhang over 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Dominic Cleal over 5 years ago

  • Tracker changed from Bug to Refactor
  • Assignee set to June Zhang
  • Legacy Backlogs Release (now unused) set to 209

Also available in: Atom PDF