Bug #18853
when acknowledging notification as read, there is no indication it is marked as read until next api call
Description
When a user marks a notification as read, there is no visual indication it has been marked as read.
the only time the notification appears as read is until the next time the notification timer gets reload the data and then its marked as read.
additionally, I can multiple times try to set it as read (as the ui doesnt change I though the api call did not execute), in the logs you can see its being triggered multiple times:
Started PUT "/notification_recipients/1" for 10.35.3.218 at 2017-03-09 12:52:47 +0000 Processing by NotificationRecipientsController#update as JSON Parameters: {"seen"=>true, "id"=>"1", "notification_recipient"=>{"seen"=>true}} Completed 200 OK in 14ms (Views: 0.4ms | ActiveRecord: 2.5ms) Started PUT "/notification_recipients/1" for 10.35.3.218 at 2017-03-09 12:52:48 +0000 Processing by NotificationRecipientsController#update as JSON Parameters: {"seen"=>true, "id"=>"1", "notification_recipient"=>{"seen"=>true}} Completed 200 OK in 14ms (Views: 0.4ms | ActiveRecord: 2.5ms) Started PUT "/notification_recipients/1" for 10.35.3.218 at 2017-03-09 12:52:48 +0000 Processing by NotificationRecipientsController#update as JSON Parameters: {"seen"=>true, "id"=>"1", "notification_recipient"=>{"seen"=>true}} Completed 200 OK in 14ms (Views: 0.4ms | ActiveRecord: 2.5ms) Started PUT "/notification_recipients/1" for 10.35.3.218 at 2017-03-09 12:52:51 +0000 Processing by NotificationRecipientsController#update as JSON Parameters: {"seen"=>true, "id"=>"1", "notification_recipient"=>{"seen"=>true}} Completed 200 OK in 14ms (Views: 0.5ms | ActiveRecord: 2.5ms) Started PUT "/notification_recipients/1" for 10.35.3.218 at 2017-03-09 12:52:51 +0000
Associated revisions
History
#1
Updated by Liza Gilman over 5 years ago
- Assignee set to Liza Gilman
#2
Updated by The Foreman Bot over 5 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/4379 added
#3
Updated by The Foreman Bot about 5 years ago
- Pull request https://github.com/theforeman/foreman/pull/4401 added
#4
Updated by Ohad Levy about 5 years ago
- Pull request deleted (
https://github.com/theforeman/foreman/pull/4379)
#5
Updated by Ohad Levy about 5 years ago
- Assignee changed from Liza Gilman to matan werbner
#6
Updated by matan werbner about 5 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset a29d54389e9c00e55c7824e53fb407c9e3e206cd.
#7
Updated by Ohad Levy about 5 years ago
- Legacy Backlogs Release (now unused) set to 209
Fixes #18957,#18193,#18678,#18853 - notifications redux
Refactored notifications to work with redux, fixed
several UI related bugs, added tests.
flux is now unused, this is based on @gailsteiger's
previous work.