Project

General

Profile

Bug #18929

rails-observer dependency required for TopbarSweeper

Added by Dominic Cleal about 2 years ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Packaging
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

I erroneously removed the explicit rails-observer dep in #14434, but the sweeper functionality used by TopbarSweeper is provided by the rails-observer gem, so the dependency should be restored. (At least while TopbarSweeper exists; I think the remainder of the token refactoring in #14434 remains beneficial.)

Currently rails-observer is installed as a dependency of the audited gem, so it does still work.

Associated revisions

Revision 73e9ceb8 (diff)
Added by Dominic Cleal about 2 years ago

fixes #18929 - add rails-observers dep for TopbarSweeper

0443e85 was in error in removing the dependency, as this sweeper
functionality is also provided by rails-observers.

Revision 5e8ada8e (diff)
Added by Dominic Cleal about 2 years ago

fixes #18929 - add rails-observers dep for TopbarSweeper

0443e85 was in error in removing the dependency, as this sweeper
functionality is also provided by rails-observers.

(cherry picked from commit 73e9ceb89fd774237f817276228aa85fd9b72efd)

History

#1 Updated by The Foreman Bot about 2 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4382 added

#2 Updated by Dominic Cleal about 2 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal about 2 years ago

  • Legacy Backlogs Release (now unused) set to 227

Also available in: Atom PDF