Actions
Bug #18958
closedUnattendedController test sets multiple remote IPs incorrectly in REMOTE_ADDR
Description
The test "UnattendedControllerTest#test_0006_should get a preseed finish script with multiple ips in the request header" sets up multiple remote IPs in REMOTE_ADDR with:
@request.env["REMOTE_ADDR"] = [@ub_host.ip, '1.2.3.4']
however environment variables should be only strings, not complex objects (an array). This may cause an issue if request.ip
is called from a controller or library, as rack will attempt to split the string:
https://github.com/rack/rack/blob/2.0.1/lib/rack/request.rb#L257
https://github.com/rack/rack/blob/2.0.1/lib/rack/request.rb#L476
(seen during modifications to audited, which records request IP addresses by calling request.ip
)
Actions