Project

General

Profile

Bug #18996

User#visible_environments limits to misspelt "view_environemnts" permissions

Added by Dominic Cleal over 5 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Category:
Users, Roles and Permissions
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

The User#visible_environments method added in #17463 has a spelling mistakes in the view_environments permission name: https://github.com/theforeman/foreman/commit/273f928#diff-4676c008b11a5480d73d4a6de01e45b9R388

This will probably cause no environments to be visible to non-admin users.

Though untested, it may have the same effect as #18995 and cause the importer to try to remove invisible environments rather than ignore them.


Related issues

Related to Foreman - Bug #17463: Importing classes for a new org fails when the environment already exist in a different orgClosed2016-11-23

Associated revisions

Revision f4b7c52f (diff)
Added by Daniel Lobato Garcia about 5 years ago

Fixes #18995, #18996 - visible_environments works w/o taxonomies

Revision d733a555 (diff)
Added by Daniel Lobato Garcia about 5 years ago

Fixes #18995, #18996 - visible_environments works w/o taxonomies

History

#1 Updated by Dominic Cleal over 5 years ago

  • Related to Bug #17463: Importing classes for a new org fails when the environment already exist in a different org added

#2 Updated by Daniel Lobato Garcia about 5 years ago

Fixed in https://github.com/theforeman/foreman/pull/4510 - will close this one when that one gets merged

#3 Updated by The Foreman Bot about 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Daniel Lobato Garcia
  • Pull request https://github.com/theforeman/foreman/pull/4510 added

#4 Updated by Anonymous about 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF