Bug #19017
Use request id instead of session id of tagged logging
Description
#15863 introduced tagged logging. In the review discussion, it was suggested to use session id
if available. Although it seemed as a good idea at the beginning, it has several disadvanteges:
- it treats UI and API requests differently
- it makes it impossible to differentiate requests made from the session at the same time (notifications
is one example, but in general, we should not assume the user is performing on request at a time) - the usability of this as correlation id is questionable, especially with asynchronous actions in place
Related issues
Associated revisions
History
#1
Updated by The Foreman Bot over 5 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/4410 added
#2
Updated by Ivan Necas over 5 years ago
- Related to Feature #15863: Log request IDs (tagged logging) in production.log added
#3
Updated by Ivan Necas over 5 years ago
- Status changed from Ready For Testing to Closed
- Bugzilla link set to 1408420
#4
Updated by Ivan Necas over 5 years ago
- Subject changed from Use request id instead of session id of lagged logging to Use request id instead of session id of tagged logging
- Category set to Logging
#5
Updated by Ohad Levy over 5 years ago
- Legacy Backlogs Release (now unused) set to 209
#6
Updated by Ivan Necas about 5 years ago
- Target version set to 1.12.2
Fixes #19017 - prefer request id over session id in logging