Project

General

Profile

Feature #19031

update table pagination to use patternfly guidelines

Added by Ohad Levy almost 6 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Liza Gilman
Category:
Web Interface
Target version:
1.16.0
Difficulty:
Triaged:
Bugzilla link:
1563277
Pull request:
https://github.com/theforeman/foreman/pull/4550
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

based on http://www.patternfly.org/pattern-library/navigation/pagination

This also makes sense to align with Katello usage cases, as they now started to use pagination and implemented the same patternfly style.

Related issues

Related to foreman-tasks - Bug #20443: pagination on task list is brokenClosed2017-07-30
Related to Foreman - Bug #20446: Search breaks paginationClosed2017-07-31
Related to Foreman - Bug #20448: selected host list counter is no longer visibleClosed2017-07-31
Related to Discovery - Feature #20450: update pagination to patternfly styleClosed2017-07-31
Related to Foreman - Bug #20454: Patternfly pagination does not support entering a page numberClosed2017-07-31
Related to Foreman - Bug #20705: Pagination links broken on audit pageClosed2017-08-23
Related to Foreman - Bug #20965: pagination on assign selected hosts to organization/location is brokenNew2017-09-17
Related to Foreman - Bug #24261: pagination CSS is wrong on assign hosts for taxonomyResolved

Associated revisions

Revision a154c816 (diff)
Added by Liza Gilman over 5 years ago

Fixes #19031 - move to patternfly pagination style

History

#2 Updated by Ohad Levy almost 6 years ago

I've started a POC at https://github.com/ohadlevy/foreman/commit/1b41e452d80e2cc6c4a2b9b3febd2d448b4c2cbd

it still requires some work, but hopefully it would help you getting started?

#3 Updated by Liza Gilman almost 6 years ago

Ohad Levy wrote:

I've started a POC at https://github.com/ohadlevy/foreman/commit/1b41e452d80e2cc6c4a2b9b3febd2d448b4c2cbd

it still requires some work, but hopefully it would help you getting started?

I got something based on that, thanks!

https://github.com/theforeman/foreman/commit/04403ca56259daf1b0e8dbc02ec3e6218662fa5f

If I'm not missing anything, it covers [2] to [6] at patternfly pagination documentation

http://www.patternfly.org/pattern-library/navigation/pagination/#/design)

#4 Updated by The Foreman Bot almost 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4550 added

#5 Updated by Liza Gilman over 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by Tomer Brisker over 5 years ago

  • Legacy Backlogs Release (now unused) set to 240

#7 Updated by Ohad Levy over 5 years ago

  • Related to Bug #20443: pagination on task list is broken added

#8 Updated by Ohad Levy over 5 years ago

  • Related to Bug #20446: Search breaks pagination added

#9 Updated by Ohad Levy over 5 years ago

  • Related to Bug #20448: selected host list counter is no longer visible added

#10 Updated by Ohad Levy over 5 years ago

  • Related to Feature #20450: update pagination to patternfly style added

#11 Updated by Adam Ruzicka over 5 years ago

  • Related to Bug #20454: Patternfly pagination does not support entering a page number added

#12 Updated by Marek Hulán over 5 years ago

  • Related to Bug #20705: Pagination links broken on audit page added

#13 Updated by Tomer Brisker over 5 years ago

  • Related to Bug #20965: pagination on assign selected hosts to organization/location is broken added

#14 Updated by Tomer Brisker almost 5 years ago

  • Bugzilla link set to 1563277

#15 Updated by Ohad Levy over 4 years ago

  • Related to Bug #24261: pagination CSS is wrong on assign hosts for taxonomy added

Also available in: Atom PDF