Feature #19031

update table pagination to use patternfly guidelines

Added by Ohad Levy about 1 year ago. Updated 3 months ago.

Status:Closed
Priority:Normal
Assigned To:Liza Gilman
Category:Web Interface
Target version:-
Difficulty: Bugzilla link:1563277
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4550
Story points-
Velocity based estimate-
Release1.16.0Release relationshipAuto

Description

based on http://www.patternfly.org/pattern-library/navigation/pagination

This also makes sense to align with Katello usage cases, as they now started to use pagination and implemented the same patternfly style.


Related issues

Related to Bastion - Refactor #18985: Replace infinite scroll with pagination Closed 03/22/2017
Related to foreman-tasks - Bug #20443: pagination on task list is broken Closed 07/30/2017
Related to Foreman - Bug #20446: Search breaks pagination Closed 07/31/2017
Related to Foreman - Bug #20448: selected host list counter is no longer visible Closed 07/31/2017
Related to Discovery - Feature #20450: update pagination to patternfly style Closed 07/31/2017
Related to Foreman - Bug #20454: Patternfly pagination does not support entering a page nu... Closed 07/31/2017
Related to Foreman - Bug #20705: Pagination links broken on audit page Closed 08/23/2017
Related to Foreman - Bug #20965: pagination on assign selected hosts to organization/locat... New 09/17/2017

Associated revisions

Revision a154c816
Added by Liza Gilman 11 months ago

Fixes #19031 - move to patternfly pagination style

History

#1 Updated by Ohad Levy about 1 year ago

  • Related to Refactor #18985: Replace infinite scroll with pagination added

#2 Updated by Ohad Levy about 1 year ago

I've started a POC at https://github.com/ohadlevy/foreman/commit/1b41e452d80e2cc6c4a2b9b3febd2d448b4c2cbd

it still requires some work, but hopefully it would help you getting started?

#3 Updated by Liza Gilman about 1 year ago

Ohad Levy wrote:

I've started a POC at https://github.com/ohadlevy/foreman/commit/1b41e452d80e2cc6c4a2b9b3febd2d448b4c2cbd

it still requires some work, but hopefully it would help you getting started?

I got something based on that, thanks!

https://github.com/theforeman/foreman/commit/04403ca56259daf1b0e8dbc02ec3e6218662fa5f

If I'm not missing anything, it covers [2] to [6] at patternfly pagination documentation

http://www.patternfly.org/pattern-library/navigation/pagination/#/design)

#4 Updated by The Foreman Bot about 1 year ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4550 added

#5 Updated by Liza Gilman 11 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by Tomer Brisker 11 months ago

  • Release set to 1.16.0

#7 Updated by Ohad Levy 11 months ago

  • Related to Bug #20443: pagination on task list is broken added

#8 Updated by Ohad Levy 11 months ago

  • Related to Bug #20446: Search breaks pagination added

#9 Updated by Ohad Levy 11 months ago

  • Related to Bug #20448: selected host list counter is no longer visible added

#10 Updated by Ohad Levy 11 months ago

  • Related to Feature #20450: update pagination to patternfly style added

#11 Updated by Adam Ruzicka 11 months ago

  • Related to Bug #20454: Patternfly pagination does not support entering a page number added

#12 Updated by Marek Hulán 10 months ago

  • Related to Bug #20705: Pagination links broken on audit page added

#13 Updated by Tomer Brisker 9 months ago

  • Related to Bug #20965: pagination on assign selected hosts to organization/location is broken added

#14 Updated by Tomer Brisker 3 months ago

  • Bugzilla link set to 1563277

Also available in: Atom PDF