Project

General

Profile

Refactor #19035

Refactor TopbarSweeper to remove rails-observer dependency

Added by Dominic Cleal over 5 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
Rails
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

The rails-observer project is currently incompatible with Rails 5 and higher, and looks unlikely to be made compatible and released in the near future.

The TopbarSweeper uses rails-observer to clear user topbar caches when user/group/role etc. objects are updated from a controller, but this could be refactored into a model concern. The audited gem is also dropping its dependency, so refactoring TopbarSweeper would allow the dependency to be entirely dropped from Foreman (the original intention of #14434).


Related issues

Blocks Foreman - Tracker #15715: Rails 5.0 upgrade tasksResolved2016-07-18

Associated revisions

Revision 0e52ebb7 (diff)
Added by Dominic Cleal about 5 years ago

fixes #19035 - rewrite TopbarSweeper without rails-observers

Moves from the observer object into two mixins, one on the model and one
on the top-level controllers to observe creates/updates/destroys on
monitored models. Replaces rails-observers as it lacks Rails 5 support.

Revision e1f3f867 (diff)
Added by Dominic Cleal about 5 years ago

refs #19035 - remove rails-observers dependency

History

#1 Updated by Dominic Cleal over 5 years ago

#2 Updated by The Foreman Bot over 5 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4417 added

#3 Updated by Dominic Cleal about 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Ohad Levy about 5 years ago

  • Legacy Backlogs Release (now unused) set to 209

Also available in: Atom PDF