Project

General

Profile

Feature #19050

Add support for running under Ruby on Rails 5.0

Added by Dominic Cleal over 1 year ago. Updated 2 months ago.


Description

Add support to Foreman core for running under Ruby on Rails 5.0, in addition to version 4.2 (for support of Ruby versions 2.0, 2.1 and earlier 2.2).


Related issues

Related to Foreman - Tracker #19577: Drop Ruby 2.1 supportClosed2017-05-17

Blocks Foreman - Tracker #15715: Rails 5.0 upgrade tasksResolved2016-07-18

Blocked by Foreman - Refactor #18982: Refactor params hash iteration in Api::CompatibilityChecker#check_create_host_nestedClosed2017-03-22
Blocked by Foreman - Refactor #19085: TokenTest expiry fails on MySQL with Rails 5.0, it should be removedClosed2017-03-30
Blocked by Foreman - Bug #19087: UINotificationsHostsBuildCompletedTest failures with MySQL on Rails 5.0Closed2017-03-30

Associated revisions

Revision 6d9f34fe (diff)
Added by Dominic Cleal about 1 year ago

fixes #19050 - add Ruby on Rails 5.0 support

Adds configurable support for running on Ruby on Rails 5.0 or 4.2,
defaulting now to 5.0 on Ruby 2.3 or higher. Ruby versions with partial
or no support remain using 4.2 by default. Other points:

1. SETTINGS[:rails] is loaded pre-Rails boot, then post-boot the
majority of the SETTINGS are loaded depending on the environment.
settings.yaml.dist will allow packagers to override the default
version of Rails loaded to match their distribution.
2. rails-controller-testing, record_tag_helper replace extracted Rails
4.x features.
3. ParamsParser middleware is no longer loaded by default and is
deprecated, CatchJsonParseErrors is no longer order dependent.
4. quiet_assets is not supported under Rails 5, will be replaced under
ticket #18500, only affects development logging.

Revision 8121cd5f (diff)
Added by Michael Moll about 1 year ago

Refs #19050 - set defaults Rails version to 4.2

https://github.com/rails/rails/issues/25046 is hitting plugin tests.

Revision a19834d8 (diff)
Added by Michael Moll about 1 year ago

Refs #19050 - Update Rails 5.0 to 5.0.6

Revision 36e533a1 (diff)
Added by Michael Moll 12 months ago

Refs #19050 - Use Rails 4.2 on Ruby 2.3

This unbreaks Ubuntu/xenial and Debian/stretch nightlies

Revision 72cdd2c4 (diff)
Added by Michael Moll 11 months ago

Refs #19050 - Use Rails 5.0 on Ruby 2.3 again (#4933)

This reverts commit 36e533a1fa921b062fadea51a35871bbfe2fc24c.

History

#1 Updated by Dominic Cleal over 1 year ago

#2 Updated by The Foreman Bot over 1 year ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4422 added

#3 Updated by Dominic Cleal over 1 year ago

  • Blocked by Refactor #18982: Refactor params hash iteration in Api::CompatibilityChecker#check_create_host_nested added

#4 Updated by Dominic Cleal over 1 year ago

  • Blocked by Refactor #19085: TokenTest expiry fails on MySQL with Rails 5.0, it should be removed added

#5 Updated by Dominic Cleal over 1 year ago

  • Blocked by Bug #19087: UINotificationsHostsBuildCompletedTest failures with MySQL on Rails 5.0 added

#6 Updated by The Foreman Bot about 1 year ago

  • Pull request https://github.com/theforeman/foreman/pull/4642 added

#7 Updated by Ohad Levy about 1 year ago

  • Legacy Backlogs Release (now unused) set to 240

#8 Updated by Dominic Cleal about 1 year ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#9 Updated by The Foreman Bot about 1 year ago

  • Pull request https://github.com/theforeman/foreman/pull/4649 added

#10 Updated by The Foreman Bot about 1 year ago

  • Pull request https://github.com/theforeman/foreman/pull/4709 added

#11 Updated by Michael Moll about 1 year ago

#12 Updated by The Foreman Bot 12 months ago

  • Pull request https://github.com/theforeman/foreman/pull/4873 added

#13 Updated by The Foreman Bot 11 months ago

  • Pull request https://github.com/theforeman/foreman/pull/4933 added

Also available in: Atom PDF