Actions
Bug #19067
closedUnintuitive diff colors
Difficulty:
Triaged:
No
Description
When viewing diffs in Foreman, such as filebucket diffs in puppet reports, or history diffs in provisioning templates et al, added lines show up in black, and removed lines show up in green. Also, these two colors are reversed for the + and - symbols prefixing the lines (+ in green, - in black).
I suggest using green for additions (+), red for removals (-), and using the same color for the prefix symbol as the rest of the line.
Updated by The Foreman Bot about 6 years ago
- Pull request https://github.com/theforeman/foreman/pull/6138 added
Updated by The Foreman Bot about 6 years ago
- Status changed from New to Ready For Testing
Updated by The Foreman Bot about 6 years ago
- Pull request https://github.com/theforeman/foreman/pull/6180 added
Updated by Ohad Levy about 6 years ago
- Target version set to 1.21.0
- Pull request deleted (
https://github.com/theforeman/foreman/pull/6180) - Fixed in Releases 1.21.0 added
Updated by Ohad Levy about 6 years ago
just for clarification, this adds Diff for the audit page, follow up pull requests to other places where diff is shown in the app will follow.
Updated by Anonymous about 6 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset b674b25e1ec2eca232d993ef90ea2ee6356a36e1.
Updated by The Foreman Bot about 6 years ago
- Pull request https://github.com/theforeman/foreman/pull/6180 added
Updated by The Foreman Bot about 6 years ago
- Assignee set to Ohad Levy
- Pull request https://github.com/theforeman/foreman/pull/6256 added
Updated by Ohad Levy about 6 years ago
- Related to Feature #25439: Add new DiffView to Config Reports added
Updated by Tomer Brisker almost 6 years ago
- Pull request deleted (
https://github.com/theforeman/foreman/pull/6180)
Actions