Project

General

Profile

Actions

Bug #19067

closed

Unintuitive diff colors

Added by J. A. almost 7 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
Web Interface
Target version:
Fixed in Releases:
Found in Releases:

Description

When viewing diffs in Foreman, such as filebucket diffs in puppet reports, or history diffs in provisioning templates et al, added lines show up in black, and removed lines show up in green. Also, these two colors are reversed for the + and - symbols prefixing the lines (+ in green, - in black).

I suggest using green for additions (+), red for removals (-), and using the same color for the prefix symbol as the rest of the line.


Related issues 1 (0 open1 closed)

Related to Foreman - Feature #25439: Add new DiffView to Config ReportsClosedGilad LeknerActions
Actions #1

Updated by Dominic Cleal almost 7 years ago

  • Category set to Web Interface
Actions #2

Updated by Ohad Levy almost 7 years ago

  • Assignee set to matan werbner
Actions #3

Updated by Anonymous almost 6 years ago

  • Assignee deleted (matan werbner)

unassign, still an issue.

Actions #4

Updated by The Foreman Bot over 5 years ago

  • Pull request https://github.com/theforeman/foreman/pull/6138 added
Actions #5

Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
Actions #6

Updated by The Foreman Bot over 5 years ago

  • Pull request https://github.com/theforeman/foreman/pull/6180 added
Actions #7

Updated by Ohad Levy over 5 years ago

  • Target version set to 1.21.0
  • Pull request deleted (https://github.com/theforeman/foreman/pull/6180)
  • Fixed in Releases 1.21.0 added
Actions #8

Updated by Ohad Levy over 5 years ago

just for clarification, this adds Diff for the audit page, follow up pull requests to other places where diff is shown in the app will follow.

Actions #9

Updated by Anonymous over 5 years ago

  • Status changed from Ready For Testing to Closed
Actions #10

Updated by The Foreman Bot over 5 years ago

  • Pull request https://github.com/theforeman/foreman/pull/6180 added
Actions #11

Updated by The Foreman Bot over 5 years ago

  • Assignee set to Ohad Levy
  • Pull request https://github.com/theforeman/foreman/pull/6256 added
Actions #12

Updated by Ohad Levy over 5 years ago

Actions #13

Updated by Tomer Brisker about 5 years ago

  • Pull request deleted (https://github.com/theforeman/foreman/pull/6180)
Actions

Also available in: Atom PDF