Project

General

Profile

Bug #19067

Unintuitive diff colors

Added by J. A. over 3 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Low
Assignee:
Ohad Levy
Category:
Web Interface
Target version:
1.21.0
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/6256, https://github.com/theforeman/foreman/pull/6138
Fixed in Releases:
1.21.0
Found in Releases:

Description

When viewing diffs in Foreman, such as filebucket diffs in puppet reports, or history diffs in provisioning templates et al, added lines show up in black, and removed lines show up in green. Also, these two colors are reversed for the + and - symbols prefixing the lines (+ in green, - in black).

I suggest using green for additions (+), red for removals (-), and using the same color for the prefix symbol as the rest of the line.

Related issues

Related to Foreman - Feature #25439: Add new DiffView to Config ReportsClosed

Associated revisions

Revision b674b25e (diff)
Added by Gilad Lekner about 2 years ago

Fixes #19067 - React DiffView Component

Revision d16e5909 (diff)
Added by Ohad Levy about 2 years ago

refs #19067 - adds react-diff-view to vendor file

this avoids the package to being duplicated when used by plugins.

before (on foreman + rex + ansible plugins)

All (5.3 MB)
vendor-1c326de93e364f3d92c2.js (4.07 MB)
foreman_ansible-824cba753b2f8e3afd08.js (445.93 KB)
bundle-96cce9ae71e71f78eb9f.js (424.3 KB)
foreman_remote_execution-3f8355b3cc3b3cc399b8.js (393.61 KB)

after:

All (5 MB)
vendor-ea25bb4408e14b8aa07a.js (4.21 MB)
foreman_ansible-37e250519f35a92fa4c0.js (294.93 KB)
bundle-135f6abcfbdd882efd78.js (273.29 KB)
foreman_remote_execution-459ed3afbe82bf66388e.js (242.61 KB)

History

#1 Updated by Dominic Cleal over 3 years ago

  • Category set to Web Interface

#2 Updated by Ohad Levy over 3 years ago

  • Assignee set to matan werbner

#3 Updated by Anonymous over 2 years ago

  • Assignee deleted (matan werbner)

unassign, still an issue.

#4 Updated by The Foreman Bot about 2 years ago

  • Pull request https://github.com/theforeman/foreman/pull/6138 added

#5 Updated by The Foreman Bot about 2 years ago

  • Status changed from New to Ready For Testing

#6 Updated by The Foreman Bot about 2 years ago

  • Pull request https://github.com/theforeman/foreman/pull/6180 added

#7 Updated by Ohad Levy about 2 years ago

  • Target version set to 1.21.0
  • Fixed in Releases 1.21.0 added
  • Pull request deleted (https://github.com/theforeman/foreman/pull/6180)

#8 Updated by Ohad Levy about 2 years ago

just for clarification, this adds Diff for the audit page, follow up pull requests to other places where diff is shown in the app will follow.

#9 Updated by Anonymous about 2 years ago

  • Status changed from Ready For Testing to Closed

#10 Updated by The Foreman Bot about 2 years ago

  • Pull request https://github.com/theforeman/foreman/pull/6180 added

#11 Updated by The Foreman Bot about 2 years ago

  • Assignee set to Ohad Levy
  • Pull request https://github.com/theforeman/foreman/pull/6256 added

#12 Updated by Ohad Levy about 2 years ago

#13 Updated by Tomer Brisker almost 2 years ago

  • Pull request deleted (https://github.com/theforeman/foreman/pull/6180)

Also available in: Atom PDF