Project

General

Profile

Actions

Feature #19104

closed

Ignore tagged includes for ISC DHCP

Added by Lukas Zapletal about 7 years ago. Updated about 7 years ago.

Status:
Rejected
Priority:
Normal
Category:
DHCP
Target version:
-
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Our parser limitations is a real pain, I stubmbled this upon at customer again. This is a simple idea to allow at least workarounding this by including files from a directory with "igored-by-foreman" element. All these files will not be included at all, so the workaround is then:

subnet XYZ {
valid_syntax;
include "/etc/dhcpd/ignored-by-foreman/invalid_subnet_xyz.conf"
}


Related issues 1 (0 open1 closed)

Related to Smart Proxy - Bug #17800: ISC Dhcpd Config Parse ErrorDuplicate12/20/2016Actions
Actions #1

Updated by The Foreman Bot about 7 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Lukas Zapletal
  • Pull request https://github.com/theforeman/smart-proxy/pull/517 added
Actions #2

Updated by Lukas Zapletal about 7 years ago

  • Related to Bug #17800: ISC Dhcpd Config Parse Error added
Actions #3

Updated by Dominic Cleal about 7 years ago

What is the "parser limitation" precisely, and what's the issue number for the parsing issue? The sample above only shows valid syntax.

Actions #4

Updated by Lukas Zapletal about 7 years ago

  • Status changed from Ready For Testing to Rejected

Our parser don't handle nested curly braces in the subnet block correctly. Some cases were short-term-fixed by lookahead regexp but not all cases. Anyway I am closing this one.

Actions

Also available in: Atom PDF