Actions
Bug #19176
closed
Parameters and plurals incorrectly translated in select all hosts related strings
Description
#16043 has a number of bad string extractions for translation, in violation of Translating.
- A few instances where a variable is interpolated before being passed to
_(), e.g._("Reminder: <strong> All #{hosts.size} hosts are selected </strong>") - Many instances where the source string uses plural language, but the
n_()plural method isn't used, e.g. the line above or__("Select all<b> %s </b> hosts") - Trailing whitespace in translated strings, e.g.
__("All <b> %d </b> hosts are selected. "). If significant, it should be added after translation.
Updated by Dominic Cleal about 7 years ago
- Related to Bug #16043: Unable to select all hosts from the GUI added
Updated by Dominic Cleal about 7 years ago
- translation missing: en.field_release set to 209
(to match the cause ticket)
Updated by
Updated by Amir Fefer about 7 years ago
I don't quite sure if plural method suits in this case,
those sentences should be always in plural, because it about multiple host selection, right?
Updated by The Foreman Bot about 7 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/4457 added
Updated by Dominic Cleal about 7 years ago
Amir Fefer wrote:
those sentences should be always in plural, because it about multiple host selection, right?
If they're always multiple then they absolutely should be using plural translation functions. Plural forms are more complex than simply one or many. (And in any case, "multiple" may still be one host.)
Updated by Amir Fefer almost 7 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 514767df2bdc0e95f9786c380ff55981b8e98c29.
Actions