Project

General

Profile

Bug #1920

Template URLs should not be based on the browser address bar

Added by Greg Sutcliffe almost 10 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Greg Sutcliffe
Category:
Templates
Target version:
1.1
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

Templates are generated using url_for() which causes the templates to get the base url of the foreman server from the user's web browser address. This is incorrect if you're installing Foreman locally and accessing http://localhost:3000/

We should instead use the Settings[:foreman_url] value to construct the URLs. Patch incoming.

Associated revisions

Revision f343e91a (diff)
Added by Greg Sutcliffe almost 10 years ago

Fixes #1920 - Template URLs should not be based on the browser address bar

Revision 9f6de1e7 (diff)
Added by Greg Sutcliffe almost 10 years ago

Refs #1920 : Fix failing tests for Setting[:foreman_url] Ensure plain 'http' protocol is used in templates Add a test to ensure http is used when https is in @request

History

#1 Updated by Anonymous almost 10 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF