Project

General

Profile

Actions

Refactor #19340

closed

new_host vs new_vm variable in compute resource VM partials

Added by Bernhard Suttner almost 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Compute resources
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

new_host was replaced by new_vm because of:
https://github.com/theforeman/foreman/commit/637da2f28accc1378f0326d97adcbb2efc5d9808

There are still 2 places (vmware name, vmware volume disk_mode) in which new_host is used in:
app/views/compute_resources_vms/form/vmware/_volume.html.erb

Actions #1

Updated by Dominic Cleal almost 7 years ago

  • Tracker changed from Bug to Refactor
  • Subject changed from new_host vs new_vm to new_host vs new_vm variable in compute resource VM partials
  • Category set to Compute resources
Actions #2

Updated by Stefan Heil almost 7 years ago

  • Related to Bug #19566: Creating a new host VM on xen fails with: undefined method `new_host?' added
Actions #3

Updated by Luke Huxley almost 7 years ago

  • Priority changed from Normal to High

Bernhard Suttner wrote:

new_host was replaced by new_vm because of:
https://github.com/theforeman/foreman/commit/637da2f28accc1378f0326d97adcbb2efc5d9808

There are still 2 places (vmware name, vmware volume disk_mode) in which new_host is used in:
app/views/compute_resources_vms/form/vmware/_volume.html.erb

This change seems to have broken provision on XenServer compute resources.

Actions #4

Updated by Timo Goebel almost 7 years ago

  • Related to deleted (Bug #19566: Creating a new host VM on xen fails with: undefined method `new_host?' )
Actions #5

Updated by The Foreman Bot almost 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4549 added
Actions #6

Updated by Timo Goebel almost 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #7

Updated by Marek Hulán almost 7 years ago

  • translation missing: en.field_release set to 240
Actions

Also available in: Atom PDF