Project

General

Profile

Bug #19354

associated_type is set to a wrong value in audit_extensions.rb

Added by Shimon Shtein over 1 year ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Audit Log
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

When fixing STI types for :associated field in AuditExtensions#fix_auditable_type, the type is set to the one from :auditable object instead the one from :associated field.
It looks like a copy-paste error.

Associated revisions

Revision 364c5208 (diff)
Added by Ori Rabin over 1 year ago

Fixes #17918,#19354 - Smart class parameters appear in audits

History

#1 Updated by Dominic Cleal over 1 year ago

  • Category set to Audit Log

Specifically, I think this means:

self.associated_type = auditable.type if auditable_type == "Taxonomy" && auditable

Uses the auditable type, but sets associated_type.

#2 Updated by Shimon Shtein over 1 year ago

exactly, thanks for clarifying!

#3 Updated by The Foreman Bot over 1 year ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ori Rabin
  • Pull request https://github.com/theforeman/foreman/pull/4165 added

#4 Updated by Tomer Brisker over 1 year ago

  • Status changed from Ready For Testing to Closed
  • Legacy Backlogs Release (now unused) set to 240

Also available in: Atom PDF