Project

General

Profile

Bug #19374

Facet definitions are not idempotent

Added by Shimon Shtein about 1 year ago. Updated 10 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Plugins-Engines
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

https://github.com/theforeman/foreman/blob/develop/app/models/concerns/facets/managed_host_extensions.rb#L51 uses alias_method_chain, that will create an endless call loop on second call.

Right now the only found affected scenario is call to Host#my_facet within migration.

Associated revisions

Revision 3be4ca4c (diff)
Added by Shimon Shtein about 1 year ago

Fixes #19374 - added check to fix double facet registration

History

#1 Updated by Shimon Shtein about 1 year ago

  • Bugzilla link set to 1445150

#2 Updated by The Foreman Bot about 1 year ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4484 added

#3 Updated by Shimon Shtein about 1 year ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Ivan Necas about 1 year ago

  • Target version set to 1.13.1

#5 Updated by Marek Hulán 9 months ago

  • Legacy Backlogs Release (now unused) set to 240

Also available in: Atom PDF