Project

General

Profile

Bug #19400

Issues with bookmark validator in tests

Added by Ivan Necas over 5 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ivan Necas
Category:
Tests
Target version:
1.16.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4490
Fixed in Releases:
Found in Releases:

Description

We cache the info about the tables too soon, which can lead to loading data about them before the schema is loaded.
This can mainly happen in tests (I'm facing this in plugins tests)

Associated revisions

Revision f044c69d (diff)
Added by Ivan Necas over 5 years ago

Fixes #19400 - defer loading of tables list cache

The BookmarkControllerValidator can get loaded sooner than the tables
are loaded (especially in tests).

Revision 182108f9 (diff)
Added by Ivan Necas about 5 years ago

Fixes #19400 - defer loading of tables list cache

The BookmarkControllerValidator can get loaded sooner than the tables
are loaded (especially in tests).

(cherry picked from commit f044c69d7d5ab83aa4d6787ece84ef7ba3fd06d5)

Conflicts:
app/validators/bookmark_controller_validator.rb

History

#1 Updated by The Foreman Bot over 5 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4490 added

#2 Updated by Ivan Necas over 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal over 5 years ago

  • Category set to Tests

#4 Updated by Ivan Necas about 5 years ago

  • Target version set to 1.13.1

#5 Updated by Marek Hulán almost 5 years ago

  • Legacy Backlogs Release (now unused) set to 240

Also available in: Atom PDF