Project

General

Profile

Bug #19448

After marking discovered hosts notification as read, new discovered host don't create notification

Added by Tomer Brisker about 4 years ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Category:
Discovery plugin
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:

Related issues

Blocked by Foreman - Bug #21541: Notifications should have an option to mark all as unreadClosed2017-11-01

Associated revisions

Revision a4826e21 (diff)
Added by Dominik Matoulek 3 months ago

Fixes #19448 - Improving notification about new host

Today the notification inform about one or more discovered hosts. However, this can be little confusing. So this PR improving notification to work on per host basis. That means that every discovered get own notification about discovery.

History

#1 Updated by Ohad Levy about 4 years ago

  • Status changed from New to Feedback

for the record, it does update the expiry ts of the notification. I'm in mixed feelings if we should update the read or not?

#2 Updated by Tomer Brisker about 4 years ago

IMHO think we should - if you marked discovered hosts as read, then a new host gets discovered, you'd want to get notified about that.

#3 Updated by Marek Hulán about 4 years ago

  • Status changed from Feedback to New
  • Target version changed from Discovery Plugin 9.1.0 to Discovery Plugin 12.0.0

I'm reopening this, I think people should be notified about newly discovered hosts even if they marked notification about some discovered hosts previously as read. If people are generally not interested in some kind of notification, is there a way to disable it? Something like "do not notify me in future?". Since 9.1.0 was released already, I'm resetting the target version.

#4 Updated by Ohad Levy almost 4 years ago

if there is a common understanding this should happen for all kind of notifications, you might need to change it in core:
https://github.com/theforeman/foreman/blob/develop/app/models/notification_blueprint.rb#L20

#5 Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Tomer Brisker
  • Pull request https://github.com/theforeman/foreman_discovery/pull/377 added

#6 Updated by Tomer Brisker over 3 years ago

  • Blocked by Bug #21541: Notifications should have an option to mark all as unread added

#7 Updated by Lukas Zapletal about 3 years ago

  • Target version deleted (Discovery Plugin 12.0.0)

#8 Updated by The Foreman Bot 5 months ago

  • Pull request https://github.com/theforeman/foreman_discovery/pull/528 added

#9 Updated by Tomer Brisker 4 months ago

  • Assignee changed from Tomer Brisker to Dominik Matoulek

#10 Updated by Marek Hulán 3 months ago

  • Pull request deleted (https://github.com/theforeman/foreman_discovery/pull/377)

Unlinking closed PR, it will be still referenced in history

#11 Updated by The Foreman Bot 3 months ago

  • Fixed in Releases Discovery Plugin 16.0 added

#12 Updated by Dominik Matoulek 3 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF