Bug #19448: After marking discovered hosts notification as read, new discovered host don't create notification - Discovery - Foreman

Custom queries

All issues closed in the last 3 weeks
Discovery by votes
Easy and Trivial Issues
Good first issues - Foreman core
Mine
My issues closed in the last 3 weeks
Untriaged and opened in the past two weeks

Actions

Copy link

Bug #19448

closed

After marking discovered hosts notification as read, new discovered host don't create notification

Added by Tomer Brisker over 7 years ago. Updated over 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Dominik Matoulek

Category:

Discovery plugin

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman_discovery/pull/528

Fixed in Releases:

Discovery Plugin 16.0

Found in Releases:

Red Hat JIRA:

Related issues 1 (0 open — 1 closed)

Blocked by Foreman - Bug #21541: Notifications should have an option to mark all as unread

Closed

Tomer Brisker

11/01/2017

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Ohad Levy over 7 years ago

Status changed from New to Feedback

for the record, it does update the expiry ts of the notification. I'm in mixed feelings if we should update the read or not?

Actions

Copy link

Updated by Tomer Brisker over 7 years ago

IMHO think we should - if you marked discovered hosts as read, then a new host gets discovered, you'd want to get notified about that.

Actions

Copy link

Updated by Marek Hulán over 7 years ago

Status changed from Feedback to New
Target version changed from Discovery Plugin 9.1.0 to Discovery Plugin 12.0.0

I'm reopening this, I think people should be notified about newly discovered hosts even if they marked notification about some discovered hosts previously as read. If people are generally not interested in some kind of notification, is there a way to disable it? Something like "do not notify me in future?". Since 9.1.0 was released already, I'm resetting the target version.

Actions

Copy link

Updated by Ohad Levy over 7 years ago

if there is a common understanding this should happen for all kind of notifications, you might need to change it in core:
https://github.com/theforeman/foreman/blob/develop/app/models/notification_blueprint.rb#L20

Actions

Copy link

Updated by The Foreman Bot over 7 years ago

Status changed from New to Ready For Testing
Assignee set to Tomer Brisker
Pull request https://github.com/theforeman/foreman_discovery/pull/377 added