Project

General

Profile

Bug #19479

two-pane notifications are not visible

Added by Ohad Levy over 1 year ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Notifications
Target version:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

it seems, that for a long time, two pane generated notifications are hidden from the user.


Related issues

Related to Foreman - Bug #10587: Notification flashes surpressed on subsequent actionsClosed2015-05-22

Associated revisions

Revision b9df73be (diff)
Added by Ohad Levy over 1 year ago

fixes #19479, #10587, #19500 - two pane notifications are visible

- notification is now inside the content div, allowing two-pane server
responses to include it.
- refactored all notifications to use notification helpers (notice,
warning and error) instead of direct flash manipulation
- also added the usage of flash now via the helpers, and fixed
it in a couple of places it was used incorrectly (mostly clone rendering
which does not redirect at all).
- fixed consisteny to remove trailing dots from toast messages (as it
seems most strings are without dot suffix).
- safer handing if notification div or its data is undefined.

History

#1 Updated by Ohad Levy over 1 year ago

  • Related to Bug #10587: Notification flashes surpressed on subsequent actions added

#2 Updated by The Foreman Bot over 1 year ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ohad Levy
  • Pull request https://github.com/theforeman/foreman/pull/4513 added

#3 Updated by Ohad Levy over 1 year ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal over 1 year ago

  • Category set to Notifications

#5 Updated by The Foreman Bot over 1 year ago

  • Pull request https://github.com/theforeman/foreman/pull/4523 added

#6 Updated by Marek Hulán over 1 year ago

  • Legacy Backlogs Release (now unused) set to 240

Also available in: Atom PDF