Project

General

Profile

Bug #19500

katello pages aren't loading

Added by John Mitsch over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Notifications
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

After the merging of https://github.com/theforeman/foreman/pull/4469, katello pages aren't loading and have this javascript error

bundle-cfa1a4b….js:70 Uncaught TypeError: Cannot read property 'flash' of undefined
at a (bundle-cfa1a4b….js:70)
at HTMLDocument.<anonymous> (bundle-cfa1a4b….js:70)
at HTMLDocument.dispatch (bundle-cfa1a4b….js:35)
at HTMLDocument.m.handle (bundle-cfa1a4b….js:34)
at Object.trigger (bundle-cfa1a4b….js:35)
at HTMLDocument.<anonymous> (bundle-cfa1a4b….js:35)
at Function.each (bundle-cfa1a4b….js:24)
at ce.fn.init.each (bundle-cfa1a4b….js:24)
at ce.fn.init.trigger (bundle-cfa1a4b….js:35)
at application.js:21701

This is what we are using to work around this issue: https://gist.github.com/johnpmitsch/8a12a78779f1d9f6f65c5959b9deaa00

Associated revisions

Revision b9df73be (diff)
Added by Ohad Levy over 5 years ago

fixes #19479, #10587, #19500 - two pane notifications are visible

- notification is now inside the content div, allowing two-pane server
responses to include it.
- refactored all notifications to use notification helpers (notice,
warning and error) instead of direct flash manipulation
- also added the usage of flash now via the helpers, and fixed
it in a couple of places it was used incorrectly (mostly clone rendering
which does not redirect at all).
- fixed consisteny to remove trailing dots from toast messages (as it
seems most strings are without dot suffix).
- safer handing if notification div or its data is undefined.

History

#1 Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ohad Levy
  • Pull request https://github.com/theforeman/foreman/pull/4513 added

#2 Updated by Ohad Levy over 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal over 5 years ago

  • Category set to Notifications

Also available in: Atom PDF