Project

General

Profile

Bug #19525

Tests are failling with foreman 1.16 develop on job invocatoin composer

Added by Ivan Necas about 2 years ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

A change in #19463 revealed an issue in remote execution, where we were not saving the user properly
when testing permissions. When auditing was present, it ensured the user was saved, while without
it, the saving of test user fails on password validation.


Related issues

Related to Foreman - Refactor #19463: Disable audit creation in factory_girl-created models in testsClosed2017-05-04

Associated revisions

Revision fca73ec6 (diff)
Added by Ivan Necas about 2 years ago

Fixes #19525 - fix user reparation in tests

A change in Foreman's #19463 revealed an issue in remote execution
where we were not saving the user properly when testing permissions.
When auditing was present, it ensured the user was saved, while without
it, the saving of test user fails on password validation.

This commit uses Foreman's helper method to prepare the test user
which has the user preparation set properly.

Revision 801cd57c (diff)
Added by Ivan Necas about 2 years ago

Fixes #19525 - avoid assert_equal nli

Otherwise, minitest prints warning (+ due to issue with backtrace
filtering), it ends up with `undefined method 'split' on nil`.

History

#1 Updated by Ivan Necas about 2 years ago

  • Related to Refactor #19463: Disable audit creation in factory_girl-created models in tests added

#2 Updated by The Foreman Bot about 2 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_remote_execution/pull/246 added

#3 Updated by Ivan Necas about 2 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Ivan Necas about 2 years ago

  • Target version set to 1.13.1

#5 Updated by Ivan Necas almost 2 years ago

  • Legacy Backlogs Release (now unused) set to 262

Also available in: Atom PDF