Project

General

Profile

Actions
Copy link

Refactor #19528

closed

Move FiltersHelperOverrides out of app/registries/ to permit autoloading

Added by Dominic Cleal almost 7 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Low
Assignee:
Dominic Cleal
Category:
Rails
Target version:
1.16.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4541
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

FiltersHelperOverrides has been excluded from reloading as it kept a list of role filter search overrides (http://projects.theforeman.org/projects/foreman/wiki/How_to_Create_a_Plugin#Specifying-alternate-auto-complete-path-for-Role-Filters) in a class-level variable.

This can be refactored (like #19464) to make it safe for reloading and move it into the regular services directory instead of registries. As a side effect, this will also make it more testable and less likely to leak behaviour changes between tests.

Actions
Copy link
 #1

Updated by The Foreman Bot almost 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4541 added
Actions
Copy link
 #2

Updated by Dominic Cleal almost 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Marek Hulán almost 7 years ago

  • translation missing: en.field_release set to 240
Actions
Copy link

Also available in: Atom PDF