Bug #19541: UserMailNotification records are not set up properly when a mail notification is added. - Foreman

Actions

Copy link

Bug #19541

closed

UserMailNotification records are not set up properly when a mail notification is added.

Added by Shimon Shtein almost 8 years ago. Updated almost 7 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Shimon Shtein

Category:

Rails

Target version:

1.16.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/4531

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

When assigning one-to-many associations we should use after(:create) hook to add those associations properly.

Updated by The Foreman Bot almost 8 years ago

Status changed from New to Ready For Testing
Pull request https://github.com/theforeman/foreman/pull/4531 added

Updated by Ivan Necas almost 8 years ago

Target version set to 1.13.3

Updated by Shimon Shtein almost 8 years ago

Subject changed from Fix user factory's :with_mail_notification trait to UserMailNotification records are not set up properly when a mail notification is added.

When using new in-memory objects, the association objects are not set up correctly without :inverse_of option.

to reproduce:

User.new(:login => 'zzz', :mail_notifications => [MailNotification.new]).user_mail_notifications.first.user

This statement will return nil, but should return a reference to the newly created user.
This happens due to the fact that inverse_of is not set.
After setting proper inverse_of, Active Record will point UserMailNotification#user property to the newly created user in this example.