Project

General

Profile

Bug #19630

Notifications are being created for internal admins

Added by Marek Hulán over 1 year ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Notifications
Target version:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

If notification audience is 'admin', the notification gets created for all admin accounts including internal anonymous and api admins. They won't be removed or read. The code that should be fixed is here https://github.com/theforeman/foreman/blob/1.15-stable/app/models/notification.rb#L47 it should probably add condition where.not(:login => [User::ANONYMOUS_ADMIN, User::ANONYMOUS_API_ADMIN])

EDIT: or simply add the scope "except_hidden"

Associated revisions

Revision 38b81aed (diff)
Added by Marek Hulán over 1 year ago

Fixes #19630 - ignore hidden admins

Revision e3ce3588 (diff)
Added by Marek Hulán over 1 year ago

Fixes #19630 - ignore hidden admins

History

#1 Updated by Marek Hulán over 1 year ago

  • Description updated (diff)

#2 Updated by The Foreman Bot over 1 year ago

  • Status changed from New to Ready For Testing
  • Assignee set to Marek Hulán
  • Pull request https://github.com/theforeman/foreman/pull/4551 added

#3 Updated by Marek Hulán over 1 year ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Marek Hulán over 1 year ago

  • Legacy Backlogs Release (now unused) set to 240

#5 Updated by The Foreman Bot over 1 year ago

  • Pull request https://github.com/theforeman/foreman/pull/4601 added

Also available in: Atom PDF