Project

General

Profile

Actions
Copy link

Refactor #19699

closed

Remove unnecessary monkey patching

Added by Shimon Shtein almost 7 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Shimon Shtein
Category:
-
Target version:
foreman-tasks-0.10.4
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman-tasks/pull/251, https://github.com/theforeman/foreman-tasks/pull/288
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

In host_action_subject.rb, there is monkey patching of import_host method.
It is not necessary and will cause problems once fact import process is changed.

Related issues 1 (0 open — 1 closed)

Related to Foreman - Refactor #15409: Refactor (puppet) facts out of host classes.ClosedShimon ShteinActions
Actions
Copy link
 #1

Updated by Shimon Shtein almost 7 years ago

  • Related to Refactor #15409: Refactor (puppet) facts out of host classes. added
Actions
Copy link
 #2

Updated by The Foreman Bot almost 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman-tasks/pull/251 added
Actions
Copy link
 #3

Updated by Shimon Shtein over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by The Foreman Bot over 6 years ago

  • Pull request https://github.com/theforeman/foreman-tasks/pull/288 added
Actions
Copy link
 #5

Updated by Ivan Necas over 6 years ago

  • translation missing: en.field_release set to 315
Actions
Copy link

Also available in: Atom PDF