Project

General

Profile

Refactor #19699

Remove unnecessary monkey patching

Added by Shimon Shtein over 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Difficulty:
Triaged:
Bugzilla link:

Description

In host_action_subject.rb, there is monkey patching of import_host method.
It is not necessary and will cause problems once fact import process is changed.


Related issues

Related to Foreman - Refactor #15409: Refactor (puppet) facts out of host classes.Closed

Associated revisions

Revision bdd395f9 (diff)
Added by Shimon Shtein about 3 years ago

Fixes #19699 - Removed import_host monkey patch

Once https://github.com/theforeman/foreman/pull/3649 gets in core,
there will be no need for monkey patch.
In addition, it handles changes in `#import_host` signature.

Revision 3768075c (diff)
Added by Shimon Shtein about 3 years ago

Refs #19699 - Fixed older method signature

History

#1 Updated by Shimon Shtein over 3 years ago

  • Related to Refactor #15409: Refactor (puppet) facts out of host classes. added

#2 Updated by The Foreman Bot over 3 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman-tasks/pull/251 added

#3 Updated by Shimon Shtein about 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by The Foreman Bot about 3 years ago

  • Pull request https://github.com/theforeman/foreman-tasks/pull/288 added

#5 Updated by Ivan Necas about 3 years ago

  • Legacy Backlogs Release (now unused) set to 315

Also available in: Atom PDF