Refactor #19706
closed
Don't treat DHCP leases as conflicts
Added by Lukas Zapletal over 7 years ago.
Updated over 6 years ago.
Description
Our previous code that should ignore leases was based on existence of hostnames, it used to work but no longer works in recent releases. In smart-proxy, we added explicit flag to indicate if a DHCP record is a reservation or a lease: theforeman/smart-proxy#532
This patch leverages this and removes the old hostname "hack" to proper test if the existing record is a lease or not. Conflict is not thrown in that case.
- Pull request https://github.com/theforeman/foreman/pull/4555 added
- Related to Bug #21120: Multiple DHCP orchestration is no longer possible with PXELoader added
- Status changed from New to Ready For Testing
- Assignee set to Lukas Zapletal
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
- Translation missing: en.field_release set to 311
Merged into 1.15.5 branch as well:
commit f5aaaae0a4a8282017985e2421b3198d95e56dc0
Refs: {dlobatog/1.15-stable}, 1.15.4-1-gf5aaaae0a
Author: Lukáš Zapletal <lzap@redhat.com>
AuthorDate: Fri Oct 6 12:36:10 2017 +0200
Commit: Daniel Lobato Garcia <me@daniellobato.me>
CommitDate: Fri Oct 6 12:37:05 2017 +0200
Fixes #19706 - don't treat DHCP leases as conflicts
Also available in: Atom
PDF