Project

General

Custom queries

Profile

Actions
Copy link

Refactor #19706

closed

Don't treat DHCP leases as conflicts

Added by Lukas Zapletal almost 8 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Lukas Zapletal
Category:
DHCP
Target version:
1.15.5
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4555
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Our previous code that should ignore leases was based on existence of hostnames, it used to work but no longer works in recent releases. In smart-proxy, we added explicit flag to indicate if a DHCP record is a reservation or a lease: theforeman/smart-proxy#532

This patch leverages this and removes the old hostname "hack" to proper test if the existing record is a lease or not. Conflict is not thrown in that case.

Related issues 2 (0 open — 2 closed)

Related to Smart Proxy - Feature #19666: Return record type for DHCP recortsClosedLukas Zapletal05/25/2017Actions
Related to Foreman - Bug #21120: Multiple DHCP orchestration is no longer possible with PXELoaderClosedLukas Zapletal09/27/2017Actions
#1

Updated by Lukas Zapletal almost 8 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4555 added
#2

Updated by Dominic Cleal almost 8 years ago

  • Related to Feature #19666: Return record type for DHCP recorts added
#3

Updated by Lukas Zapletal over 7 years ago

  • Related to Bug #21120: Multiple DHCP orchestration is no longer possible with PXELoader added
#4

Updated by The Foreman Bot over 7 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Lukas Zapletal
#5

Updated by Lukas Zapletal over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
#6

Updated by Lukas Zapletal over 7 years ago

  • Translation missing: en.field_release set to 311
Actions
Copy link

Also available in: Atom PDF